Re: [PATCH] staging: android: fix style issue

[Joe Perches <joe@perches.com>]

On Wed, 2014-08-20 at 15:13 +0100, Purnendu Kapadia wrote:
> checkpatch fix. add a line before the switch statement

Hello Purnendu.

This is a suboptimal patch description.

There is no generic style asking for a blank line
before a switch statement.

You are actually adding a blank line separating
declarations and code.

Specifying the change as a "checkpatch fix" is
also unnecessary.

A patch subject of

"[PATCH] staging: android: Add blank line after declaration"

with no patch description at all is probably good
enough.

> diff --git a/drivers/staging/android/sync.c b/drivers/staging/androchd/sync.c
[]
> @@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
>  			     unsigned long arg)
>  {
>  	struct sync_fence *fence = file->private_data;
> +
>  	switch (cmd) {
>  	case SYNC_IOC_WAIT:
>  		return sync_fence_ioctl_wait(fence, arg);