From: Andy Grover <agrover@redhat.com>
To: target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, hch@lst.de, nab@linux-iscsi.org,
shli@kernel.org, linux-kernel@vger.kernel.org
Subject: [RFCv2 1/4] target: Remove unneeded check in sbc_parse_cdb
Date: Wed, 20 Aug 2014 11:28:15 -0700 [thread overview]
Message-ID: <1408559298-20037-2-git-send-email-agrover@redhat.com> (raw)
In-Reply-To: <1408559298-20037-1-git-send-email-agrover@redhat.com>
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.
Signed-off-by: Andy Grover <agrover@redhat.com>
---
drivers/target/target_core_sbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index bd78d92..ebe62af 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -948,7 +948,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
}
/* reject any command that we don't have a handler for */
- if (!(cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) && !cmd->execute_cmd)
+ if (!cmd->execute_cmd)
return TCM_UNSUPPORTED_SCSI_OPCODE;
if (cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {
--
1.9.3
next prev parent reply other threads:[~2014-08-20 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 19:11 [RFC 0/2] target: userspace pass-through backend Andy Grover
2014-07-01 19:11 ` [RFC 1/2] target: Add documentation on the target userspace pass-through driver Andy Grover
2014-07-05 11:29 ` Alex Elsayed
2014-07-08 22:03 ` Andy Grover
2014-08-30 17:35 ` Richard W.M. Jones
2014-08-31 19:49 ` Andy Grover
2014-08-31 21:22 ` Richard W.M. Jones
2014-09-02 22:06 ` Andy Grover
2014-07-01 19:11 ` [RFC 2/2] target: Add a user-passthrough backstore Andy Grover
2014-07-07 21:26 ` [RFC 0/2] target: userspace pass-through backend Andy Grover
2014-07-14 15:08 ` Stefan Hajnoczi
2014-08-20 18:28 ` [RFCv2 0/4] Userspace pass-through storage engine (backend) Andy Grover
2014-08-20 18:28 ` Andy Grover [this message]
2014-08-20 18:28 ` [RFCv2 2/4] uio: Export definition of struct uio_device Andy Grover
2014-08-20 18:28 ` [RFCv2 3/4] target: Add a user-passthrough backstore Andy Grover
2014-08-20 18:28 ` [RFCv2 4/4] target: Add documentation on the target userspace pass-through driver Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408559298-20037-2-git-send-email-agrover@redhat.com \
--to=agrover@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=shli@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®