Re: [PATCH] nfs: use canonical path in nfs_show_devname

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

On Tue, 2014-08-19 at 23:06 -0400, Xiong Zhou wrote:
> When export root dir(/) via nfs, and mount a particular dir under root, eg
> /nfsexport, there will be defect double slash output in /proc/mounts, like
> localhost://nfsexport.
> 
> Signed-off-by: Xiong Zhou <xzhou@redhat.com>
> ---
>  fs/nfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index e4499d5..62b1cab 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -780,7 +780,7 @@ int nfs_show_devname(struct seq_file *m, struct dentry *root)
>  	int err = 0;
>  	if (!page)
>  		return -ENOMEM;
> -	devname = nfs_path(&dummy, root, page, PAGE_SIZE, 0);
> +	devname = nfs_path(&dummy, root, page, PAGE_SIZE, 1);
>  	if (IS_ERR(devname))
>  		err = PTR_ERR(devname);
>  	else

This will reintroduce the problem reported in
<https://bugs.debian.org/669314>.

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]