From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753901AbbK3Mdp (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Nov 2015 07:33:45 -0500
Received: from mout.kundenserver.de ([217.72.192.74]:53545 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753430AbbK3Mdo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Nov 2015 07:33:44 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] phy: sun9i-usb: add USB dependency
Date: Mon, 30 Nov 2015 13:33:01 +0100
Message-ID: <14088458.Tx1bFTs7bY@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CAGb2v67aC4VtKKMa6ORbokVBRDMOeymeWasrvoiStao44Si8YA@mail.gmail.com>
References: <2655929.DjdP30bhQY@wuerfel> <CAGb2v67aC4VtKKMa6ORbokVBRDMOeymeWasrvoiStao44Si8YA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:bNwvrjl3NsacY9NxNvj+TS3jEHJKAxwinrsM9GPS4vvjspiY/Jj
 lXE+vXAO+8HnpfbNj5ol9tuYudaNNvL7IaHKv5OBG3uZHmodIgK5f0Rz5iCU6/JLtw6KzZT
 i+I9w+rwe38WK0xO0JpyHssidQTXjazvCXPpN5HGnrDlzlvqxLs08pasExq3NFpjDgW3jv0
 NKWTgoTIoprKF7J4MGaHA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:LIawpJDLqAw=:3TZKE7zor5RRx/EPkcVNuc
 t7ctJd/+lKEuTsUchzGqk4fOp+wceCMOHnSStqQbxdpJtQeol6HqIC7Kn0J6cikSBqBKE5sxA
 ly3eZXE2MCkRu07GHoJy8YHUqOiH8fNLwCkiCS2Y19c6l763nBU7XrXM42/ruG8/IBJ8ALCfv
 rZxzC+8jBG1sMz2tVdvvmJsgBoo24vPK2Kkwg1LugDVDHiGbCKcLBPs0VoiqcIHpFMQ2iXN1N
 kJGTJ62SgZCOjmOL9XvDLe2p3wU0HtrYzTFKSLxUw2eHZxI5upr/kEhjgRG3SuO7qWMkLY6W/
 HeYuJiWw8TsqnIjrEOcHDMmXdGQH9/7qjN5eO4IdbkA4suJsMU8YIVnM+ouI/f0s1IkhGXjI0
 0UdhLsOumB27nJnCp0YUz7+C6KST/zAiCfcenu/orLshe9OZ8eWFe3mGgqPxP087fwp1z05nv
 ay3A7N7FxCrXqMvrPjqlqG928EOBPq/NtgqxDEBHhJzFoPNWeb6gPoqro30DCjsOFHKe2af88
 oV2iE9aJvGdYRpDmHO5GIorr+SU2k7XXHcpRhwtk1m++oOo6dPpNmn/L8RHziR6pV2Q3zN/oN
 In+1CXtK4m5kGEcGkKx4kyc9940TX3fzSocX2BsK7caWVcHf/okouxStDF5C55QfIvqwcaeAb
 9geqdBWQYUnYo54dPSVbDpgaXSsd4bGuyF/7hGRoozZ0qPoTLdcURYxXcDH6UeJAZI8U+ziTJ
 pXOAczBhIPp9TwA5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 30 November 2015 20:27:04 Chen-Yu Tsai wrote:
> On Mon, Nov 30, 2015 at 7:29 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The sun9i usb phy driver calls of_usb_get_phy_mode(), which is not
> > available if USB is disabled:
> >
> > drivers/built-in.o: In function `sun9i_usb_phy_probe':
> > :(.text+0x7fb0): undefined reference to `of_usb_get_phy_mode'
> >
> > This adds a dependency to avoid the randconfig build errors.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 9c3b44302636 ("phy: Add driver to support individual USB PHYs on sun9i")
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 7eb5859dd035..03cb3ea2d2c0 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -233,6 +233,7 @@ config PHY_SUN9I_USB
> >         tristate "Allwinner sun9i SoC USB PHY driver"
> >         depends on ARCH_SUNXI && HAS_IOMEM && OF
> >         depends on RESET_CONTROLLER
> > +       depends on USB_COMMON
> 
> USB_SUPPORT seems like the one to use. Some other phy drivers depend on this,
> and so does drivers/usb/phy/of.c, which is where of_usb_get_phy_mode()
> is located.

USB_SUPPORT is the user-selectable option that enables USB and USB_GADGET
to be selected, while USB_COMMON is automatically enabled if one of those
two is.

If you have USB_SUPPORT=y but both USB and USB_GADGET disabled, then
Kbuild does not enter the drivers/usb/phy directory and you still
get the build failure.

	Arnd