From: Joe Perches <joe@perches.com>
To: Greg Donald <gdonald@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '?' errors
Date: Mon, 25 Aug 2014 06:15:19 -0700 [thread overview]
Message-ID: <1408972519.20683.41.camel@joe-AO725> (raw)
In-Reply-To: <1408966502-22350-1-git-send-email-gdonald@gmail.com>
On Mon, 2014-08-25 at 06:35 -0500, Greg Donald wrote:
> Fix checkpatch.pl spaces required around that '?' errors
It'd be better to convert all parts of the
ternary at the same time.
> diff --git a/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c b/drivers/staging/rtl8821ae/btcoexist/HalBtc8812a1Ant.c
[]
> @@ -652,7 +652,7 @@ halbtc8812a1ant_SetFwDecBtPwr(
> u1Byte buf[5] = {0};
>
> BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW_EXEC, ("[BTCoex], decrease Bt Power : %s\n",
> - (dec_bt_pwr? "Yes!!":"No!!")));
> + (dec_bt_pwr ? "Yes!!":"No!!")));
(dec_bt_pwr ? "Yes!!" : "No!!")
>
> buf[0] = dataLen;
> buf[1] = 0x3; // OP_Code
> @@ -674,7 +674,7 @@ halbtc8812a1ant_DecBtPwr(
> {
> return;
> BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW, ("[BTCoex], %s Dec BT power = %s\n",
> - (force_exec? "force to":""), ((dec_bt_pwr)? "ON":"OFF")));
> + (force_exec ? "force to":""), ((dec_bt_pwr) ? "ON":"OFF")));
(force_exec ? "force to" : ""), ((dec_bt_pwr) ? "ON" : "OFF")));
etc...
A subsequent change might be to remove the unnecessary
parentheses like:
force_exec ? "force to" : "", dec_bt_pwr ? "ON" : "OFF");
next prev parent reply other threads:[~2014-08-25 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 11:35 Greg Donald
2014-08-25 13:15 ` Joe Perches [this message]
2014-08-25 13:51 ` Greg Donald
2014-08-25 13:56 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2014-08-24 23:34 [PATCH] drivers: staging: rtl8821ae: Fix spaces required around that '<' errors Greg Donald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408972519.20683.41.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®