mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: drbd-dev@lists.linbit.com
Subject: [PATCH 6/8] drbd: Get rid of the WORK_PENDING macro
Date: Mon, 25 Aug 2014 15:16:36 +0200	[thread overview]
Message-ID: <1408972598-16650-7-git-send-email-philipp.reisner@linbit.com> (raw)
In-Reply-To: <1408972598-16650-1-git-send-email-philipp.reisner@linbit.com>

From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>

This macro doesn't add any value; just use test_bit() instead.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
---
 drivers/block/drbd/drbd_worker.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index b20cd21..3b74f08 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -1931,19 +1931,18 @@ void __update_timing_details(
 	++(*cb_nr);
 }
 
-#define WORK_PENDING(work_bit, todo)	(todo & (1UL << work_bit))
 static void do_device_work(struct drbd_device *device, const unsigned long todo)
 {
-	if (WORK_PENDING(MD_SYNC, todo))
+	if (test_bit(MD_SYNC, &todo))
 		do_md_sync(device);
-	if (WORK_PENDING(RS_DONE, todo) ||
-	    WORK_PENDING(RS_PROGRESS, todo))
-		update_on_disk_bitmap(device, WORK_PENDING(RS_DONE, todo));
-	if (WORK_PENDING(GO_DISKLESS, todo))
+	if (test_bit(RS_DONE, &todo) ||
+	    test_bit(RS_PROGRESS, &todo))
+		update_on_disk_bitmap(device, test_bit(RS_DONE, &todo));
+	if (test_bit(GO_DISKLESS, &todo))
 		go_diskless(device);
-	if (WORK_PENDING(DESTROY_DISK, todo))
+	if (test_bit(DESTROY_DISK, &todo))
 		drbd_ldev_destroy(device);
-	if (WORK_PENDING(RS_START, todo))
+	if (test_bit(RS_START, &todo))
 		do_start_resync(device);
 }
 
-- 
1.9.1


  parent reply	other threads:[~2014-08-25 13:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 13:16 [PATCH 0/8] RFC DRBD cleanups and performance work Philipp Reisner
2014-08-25 13:16 ` [PATCH 1/8] drbd: Use better variable names Philipp Reisner
2014-08-25 13:16 ` [PATCH 2/8] drbd: Use consistent names for all the bi_end_io callbacks Philipp Reisner
2014-08-25 13:16 ` [PATCH 3/8] drbd: Remove superfluous newline from "resync_extents" debugfs entry Philipp Reisner
2014-08-25 13:16 ` [PATCH 4/8] drbd: Avoid inconsistent locking warning Philipp Reisner
2014-08-25 13:16 ` [PATCH 5/8] drbd: Get rid of the __no_warn and __cond_lock macros Philipp Reisner
2014-08-25 13:16 ` Philipp Reisner [this message]
2014-08-25 13:16 ` [PATCH 7/8] drbd: Improve asender performance Philipp Reisner
2014-08-25 13:16 ` [PATCH 8/8] drbd: reduce lock contention in drbd_worker Philipp Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408972598-16650-7-git-send-email-philipp.reisner@linbit.com \
    --to=philipp.reisner@linbit.com \
    --cc=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®