From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
afaerber@suse.de, Nick Dyer <nick.dyer@itdev.co.uk>,
Yufeng Shen <miletus@chromium.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad
Date: Tue, 26 Aug 2014 17:28:55 +0200 [thread overview]
Message-ID: <1409066937-3574-2-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1409066937-3574-1-git-send-email-javier.martinez@collabora.co.uk>
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
The Peach Pit board has an Atmel maXTouch trackpad device.
Add the needed Device Tree nodes to support it.
This Device Tree change is based on the Chrome OS 3.8 tree
but adapted to use the mainline Atmel maXTouch DT binding.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
[javier.martinez: added linux,gpio-keymap property and changed IRQ type]
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Changes since v1:
- Change trackpad IRQ pad function from 0x0 (GPIO input) to 0xf (GPIO IRQ).
suggested by Tomasz Figa.
- Remove BTN_TOOL_* from "linux,gpio-keymap" property since those are set
by input mt core if INPUT_MT_POINTER is set. Suggested by Nick Dyer.
- Use correct values for "linux,gpio-keymap" property. Suggested by Nick Dyer.
- Remove support for Peach Pi board since it uses a different Atmel touchpad
that requires an Atmel object protocol (T100) not supported by the driver.
- Use IRQ type constants from <dt-bindings/interrupt-controller/irq.h> instead
of magic numbers. Suggested by Andreas Farber.
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 31 ++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 228a6b1..e4f82d5 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -11,6 +11,7 @@
/dts-v1/;
#include <dt-bindings/input/input.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
#include "exynos5420.dtsi"
/ {
@@ -157,6 +158,29 @@
};
};
+&hsi2c_8 {
+ status = "okay";
+ clock-frequency = <333000>;
+
+ trackpad@4b {
+ compatible="atmel,maxtouch";
+ reg=<0x4b>;
+ interrupt-parent=<&gpx1>;
+ interrupts=<1 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-source;
+ pinctrl-names = "default";
+ pinctrl-0 = <&trackpad_irq>;
+ linux,gpio-keymap = < KEY_RESERVED
+ KEY_RESERVED
+ 0 /* GPIO 0 */
+ 0 /* GPIO 1 */
+ 0 /* GPIO 2 */
+ BTN_LEFT /* GPIO 3 */
+ KEY_RESERVED
+ KEY_RESERVED >;
+ };
+};
+
&hsi2c_9 {
status = "okay";
clock-frequency = <400000>;
@@ -249,6 +273,13 @@
samsung,pin-drv = <0>;
};
+ trackpad_irq: trackpad-irq {
+ samsung,pins = "gpx1-1";
+ samsung,pin-function = <0xf>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
power_key_irq: power-key-irq {
samsung,pins = "gpx1-2";
samsung,pin-function = <0>;
--
2.0.1
next prev parent reply other threads:[~2014-08-26 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 15:28 [PATCH v2 0/3] Add Atmel maXTouch support for Peach Pit Javier Martinez Canillas
2014-08-26 15:28 ` Javier Martinez Canillas [this message]
2014-08-26 22:53 ` [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Andreas Färber
2014-08-27 7:13 ` Javier Martinez Canillas
2014-08-27 13:11 ` Andreas Färber
2014-08-27 14:22 ` Javier Martinez Canillas
2014-09-02 13:46 ` Nick Dyer
2014-09-08 7:26 ` Javier Martinez Canillas
2014-08-26 15:28 ` [PATCH v2 2/3] ARM: exynos_defconfig: Enable Atmel maXTouch support Javier Martinez Canillas
2014-08-26 15:28 ` [PATCH v2 3/3] ARM: multi_v7_defconfig: " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409066937-3574-2-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=afaerber@suse.de \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=olof@lixom.net \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®