From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749AbaHZTDS (ORCPT ); Tue, 26 Aug 2014 15:03:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753606AbaHZTDQ (ORCPT ); Tue, 26 Aug 2014 15:03:16 -0400 Message-ID: <1409079750.2906.130.camel@ul30vt.home> Subject: Re: [RFC 8/9] KVM: KVM-VFIO: add kvm_vfio_arch_data and accessors From: Alex Williamson To: Eric Auger Cc: eric.auger@st.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, joel.schopp@amd.com, kim.phillips@freescale.com, linux-kernel@vger.kernel.org, patches@linaro.org, will.deacon@arm.com, a.motakis@virtualopensystems.com, a.rigo@virtualopensystems.com, john.liuli@huawei.com Date: Tue, 26 Aug 2014 13:02:30 -0600 In-Reply-To: <1408973264-30384-9-git-send-email-eric.auger@linaro.org> References: <1408973264-30384-1-git-send-email-eric.auger@linaro.org> <1408973264-30384-9-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-08-25 at 15:27 +0200, Eric Auger wrote: > add a pointer to architecture specific data in kvm_vfio struct > add accessors to keep kvm_vfio private > > Signed-off-by: Eric Auger > --- > arch/arm/include/asm/kvm_host.h | 8 ++++++++ > virt/kvm/vfio.c | 21 +++++++++++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > index 62cbf5b..4f1edbf 100644 > --- a/arch/arm/include/asm/kvm_host.h > +++ b/arch/arm/include/asm/kvm_host.h > @@ -177,6 +177,14 @@ void kvm_vfio_device_put_external_user(struct vfio_device *vdev); > int kvm_vfio_external_get_type(struct vfio_device *vdev); > struct device *kvm_vfio_external_get_base_device(struct vfio_device *vdev); > > +struct kvm_vfio; > +struct kvm_vfio_arch_data; > +void kvm_vfio_device_set_arch_data(struct kvm_vfio *kv, > + struct kvm_vfio_arch_data *ptr); > +struct kvm_vfio_arch_data *kvm_vfio_device_get_arch_data(struct kvm_vfio *kv); > +void kvm_vfio_lock(struct kvm_vfio *kv); > +void kvm_vfio_unlock(struct kvm_vfio *kv); > + > /* We do not have shadow page tables, hence the empty hooks */ > static inline int kvm_age_hva(struct kvm *kvm, unsigned long hva) > { > diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c > index f1c4e35..177b71e 100644 > --- a/virt/kvm/vfio.c > +++ b/virt/kvm/vfio.c > @@ -28,6 +28,7 @@ struct kvm_vfio { > struct list_head group_list; > struct mutex lock; > bool noncoherent; > + struct kvm_vfio_arch_data *arch_data; > }; > > static struct vfio_group *kvm_vfio_group_get_external_user(struct file *filep) > @@ -338,6 +339,26 @@ static int kvm_vfio_create(struct kvm_device *dev, u32 type) > return 0; > } > > +void kvm_vfio_device_set_arch_data(struct kvm_vfio *kv, > + struct kvm_vfio_arch_data *ptr) > +{ > + kv->arch_data = ptr; > +} > + > +struct kvm_vfio_arch_data *kvm_vfio_device_get_arch_data(struct kvm_vfio *kv) > +{ My preference would be s/get_// > + return kv->arch_data; > +} > + > +void kvm_vfio_lock(struct kvm_vfio *kv) > +{ > + mutex_lock(&kv->lock); > +} > + > +void kvm_vfio_unlock(struct kvm_vfio *kv) > +{ > + mutex_unlock(&kv->lock); > +} Gosh, what could go wrong... > > struct kvm_device_ops kvm_vfio_ops = { > .name = "kvm-vfio",