From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Grant Likely <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"H. Peter Anvin" <hpa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH/RFC 2/2] lib: string: Make all calls to strnicmp into calls to strncasecmp
Date: Wed, 27 Aug 2014 09:36:02 +0200 [thread overview]
Message-ID: <1409124962-11527-3-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1409124962-11527-1-git-send-email-linux@rasmusvillemoes.dk>
The previous patch made strnicmp into a wrapper for strncasecmp. This
patch makes all in-tree users of strnicmp call strncasecmp directly,
while still making sure that the strnicmp symbol can be used by
out-of-tree modules. It should be considered a temporary hack until
all in-tree callers have been converted.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
include/linux/string.h | 2 +-
lib/string.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/string.h b/include/linux/string.h
index d36977e..e6edfe5 100644
--- a/include/linux/string.h
+++ b/include/linux/string.h
@@ -41,7 +41,7 @@ extern int strcmp(const char *,const char *);
extern int strncmp(const char *,const char *,__kernel_size_t);
#endif
#ifndef __HAVE_ARCH_STRNICMP
-extern int strnicmp(const char *, const char *, __kernel_size_t);
+#define strnicmp strncasecmp
#endif
#ifndef __HAVE_ARCH_STRCASECMP
extern int strcasecmp(const char *s1, const char *s2);
diff --git a/lib/string.c b/lib/string.c
index 92c33e1..d171554 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -59,6 +59,7 @@ int strncasecmp(const char *s1, const char *s2, size_t len)
EXPORT_SYMBOL(strncasecmp);
#endif
#ifndef __HAVE_ARCH_STRNICMP
+#undef strnicmp
int strnicmp(const char *s1, const char *s2, size_t len)
{
return strncasecmp(s1, s2, len);
--
2.0.4
next prev parent reply other threads:[~2014-08-27 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 7:36 [PATCH/RFC 0/2] lib: string: Remove duplicated function Rasmus Villemoes
2014-08-27 7:36 ` [PATCH/RFC 1/2] " Rasmus Villemoes
2014-09-11 22:22 ` Andrew Morton
2014-09-12 9:01 ` Rasmus Villemoes
2014-09-12 9:43 ` Joe Perches
2014-09-12 18:52 ` Tejun Heo
2014-08-27 7:36 ` Rasmus Villemoes [this message]
2014-08-27 9:05 ` [PATCH/RFC 2/2] lib: string: Make all calls to strnicmp into calls to strncasecmp Dan Carpenter
2014-08-27 9:13 ` Rasmus Villemoes
2014-08-27 10:17 ` Dan Carpenter
2014-08-30 18:11 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409124962-11527-3-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®