From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@canonical.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Joe Lawrence <joe.lawrence@stratus.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] checkpatch: Allow commit descriptions on separate line from commit id
Date: Wed, 27 Aug 2014 18:38:21 -0700 [thread overview]
Message-ID: <1409189901.25751.16.camel@joe-AO725> (raw)
In-Reply-To: <20140827131135.6d789d26@jlaw-desktop.mno.stratus.com>
The general form for commit id and description is
'Commit <12+hexdigits> ("commit description/subject line")'
But commit logs often have relatively long commit ids and
the commit description is on a separate line like:
Some explanation as to why commit <12+hexdigits>
("commit description/subject line") is improved.
Allow this form.
Signed-off-by: Joe Perches <joe@perches.com>
Suggested-by: Joe Lawrence <joe.lawrence@stratus.com
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d89857d..4d869dd 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2133,7 +2133,10 @@ sub process {
# Check for improperly formed commit descriptions
if ($in_commit_log &&
$line =~ /\bcommit\s+[0-9a-f]{5,}/i &&
- $line !~ /\b[Cc]ommit [0-9a-f]{12,40} \("/) {
+ !($line =~ /\b[Cc]ommit [0-9a-f]{12,40} \("/ ||
+ ($line =~ /\b[Cc]ommit [0-9a-f]{12,40}\s*$/ &&
+ defined $rawlines[$linenr] &&
+ $rawlines[$linenr] =~ /^\s*\("/))) {
$line =~ /\b(c)ommit\s+([0-9a-f]{5,})/i;
my $init_char = $1;
my $orig_commit = lc($2);
next prev parent reply other threads:[~2014-08-28 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 17:11 [PATCH] checkpatch: Add test for commit id formatting style in commit log Joe Lawrence
2014-08-28 1:38 ` Joe Perches [this message]
2014-08-28 3:28 ` [PATCH] checkpatch: Allow commit descriptions on separate line from commit id Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409189901.25751.16.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=geert@linux-m68k.org \
--cc=joe.lawrence@stratus.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®