From: Stefan Hengelein <stefan.hengelein@fau.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, jkosina@suse.cz,
paul.gortmaker@windriver.com, mhocko@suse.cz, mattst88@gmail.com,
josh@joshtriplett.org, geert@linux-m68k.org, khilman@linaro.org,
Stefan Hengelein <stefan.hengelein@fau.de>,
Andreas Ruprecht <rupran@einserver.de>
Subject: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice
Date: Fri, 29 Aug 2014 15:08:20 +0200 [thread overview]
Message-ID: <1409317700-3836-1-git-send-email-stefan.hengelein@fau.de> (raw)
Every choice item of the "Build-forced no-CBs CPUs" choice had a
dependency to RCU_NOCB_CPU. It's more comprehensible if the choice
itself has the dependency instead of every choice item.
The choice itself doesn't need to be visible if there are no items
selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined.
Signed-off-by: Stefan Hengelein <stefan.hengelein@fau.de>
Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
---
init/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 197b563..d604000 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -729,6 +729,7 @@ config RCU_NOCB_CPU
choice
prompt "Build-forced no-CBs CPUs"
default RCU_NOCB_CPU_NONE
+ depends on RCU_NOCB_CPU
help
This option allows no-CBs CPUs (whose RCU callbacks are invoked
from kthreads rather than from softirq context) to be specified
@@ -737,7 +738,7 @@ choice
config RCU_NOCB_CPU_NONE
bool "No build_forced no-CBs CPUs"
- depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
+ depends on !NO_HZ_FULL_ALL
help
This option does not force any of the CPUs to be no-CBs CPUs.
Only CPUs designated by the rcu_nocbs= boot parameter will be
@@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE
config RCU_NOCB_CPU_ZERO
bool "CPU 0 is a build_forced no-CBs CPU"
- depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
+ depends on !NO_HZ_FULL_ALL
help
This option forces CPU 0 to be a no-CBs CPU, so that its RCU
callbacks are invoked by a per-CPU kthread whose name begins
@@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO
config RCU_NOCB_CPU_ALL
bool "All CPUs are build_forced no-CBs CPUs"
- depends on RCU_NOCB_CPU
help
This option forces all CPUs to be no-CBs CPUs. The rcu_nocbs=
boot parameter will be ignored. All CPUs' RCU callbacks will
--
1.9.1
next reply other threads:[~2014-08-29 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 13:08 Stefan Hengelein [this message]
2014-08-29 18:31 ` Josh Triplett
2014-09-02 17:07 ` Paul E. McKenney
2014-09-02 18:05 ` Stefan Hengelein
2014-09-02 19:11 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409317700-3836-1-git-send-email-stefan.hengelein@fau.de \
--to=stefan.hengelein@fau.de \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jkosina@suse.cz \
--cc=josh@joshtriplett.org \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mhocko@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=rupran@einserver.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®