mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
To: r.krypa@samsung.com, havner@gmail.com, m.lis@samsung.com,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Casey Schaufler <casey@schaufler-ca.com>,
	James Morris <james.l.morris@oracle.com>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Cc: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
Subject: [PATCH 2/3] Fix a bidirectional UDS connect check typo
Date: Fri, 29 Aug 2014 17:02:54 +0200	[thread overview]
Message-ID: <1409324575-12057-2-git-send-email-l.pawelczyk@samsung.com> (raw)
In-Reply-To: <1409324575-12057-1-git-send-email-l.pawelczyk@samsung.com>

The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
bidirectional check that should have checked for mutual WRITE access
between two labels. Due to a typo the second check was incorrect.

Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
---
 security/smack/smack_lsm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 478d99e..00443a9 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
 		rc = smk_bu_note("UDS connect", skp, okp->smk_known,
 					MAY_WRITE, rc);
 		if (rc == 0) {
-			rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
-			rc = smk_bu_note("UDS connect", okp, okp->smk_known,
+			rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
+			rc = smk_bu_note("UDS connect", okp, skp->smk_known,
 						MAY_WRITE, rc);
 		}
 	}
-- 
1.9.3


  reply	other threads:[~2014-08-29 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 15:02 [PATCH 1/3] Small fixes in comments describing function parameters Lukasz Pawelczyk
2014-08-29 15:02 ` Lukasz Pawelczyk [this message]
2014-08-29 17:19   ` [PATCH 2/3] Fix a bidirectional UDS connect check typo Casey Schaufler
2014-08-29 15:02 ` [PATCH 3/3] Make Smack operate on smack_known struct where it still used char* Lukasz Pawelczyk
2014-08-29 17:20   ` Casey Schaufler
2014-08-29 17:19 ` [PATCH 1/3] Small fixes in comments describing function parameters Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409324575-12057-2-git-send-email-l.pawelczyk@samsung.com \
    --to=l.pawelczyk@samsung.com \
    --cc=casey@schaufler-ca.com \
    --cc=havner@gmail.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=m.lis@samsung.com \
    --cc=r.krypa@samsung.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®