From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Mike Turquette <mturquette@linaro.org>, linux-kernel@vger.kernel.org
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Raphael Rigo <ml-arm@syscall.eu>,
Arnaud Ebalard <arno@natisbad.org>,
Simon Boulay <simon.boulay@vitec.com>,
Leigh Brown <leigh@solinno.co.uk>
Subject: [PATCH V2 0/4] clk: mvebu: Improve clock drift
Date: Tue, 2 Sep 2014 10:15:15 +0200 [thread overview]
Message-ID: <1409645719-20003-1-git-send-email-gregory.clement@free-electrons.com> (raw)
Hi Mike, Jason, Andrew and Sebastian,
Few users reported a timer drift on the Armada 370 based board such as
the mirabox or the Netgear ReadyNAS 102. This is the second series
with few improvements after the review of the 1st version.
The reason is that when the SSCG (Spread Spectrum Clock Generator) is
enabled, it shifts the frequency of the clock. The percentage is no
more than 1% but when the clock is used for a timer it leads to a
clock drift.
This series allows to correct the affected clock when the SSCG is
enabled. This drift can happen on all the mvebu SoC on the cpu clock
block (ie cpu, ddr and l2 cache). Currently the only notable effect is
for the Armada 370 because this SoC use the l2cache clock as source
for the timer. That's why even if the series allow any of the mvebu
SoC to benefit to this correction, Armada 370 is the only user of it.
The first 2 patches should go through the clk subsystem, whereas the
third one should go to the arm-soc through the mvebu tree.
The last one is just to fix a typo I found while I was reading the clk
code.
Thanks,
Gregory
Changelog:
v1 -> v2:
- made the function a370_is_sscg_enabled() a static one
- reword the comment to make clear that the formula in datasheet is
erroneous
- added a fix_sscg_deviation() callback in order to be able to deal
with the Dove case which is different from the other mvebu SoCs
Gregory CLEMENT (4):
clk: mvebu: Fix clk frequency value if SSCG is enabled
clk: mvebu: armada-370: Fix timer drift caused by the SSCG deviation
ARM: mvebu: add SSCG to Armada 370 Device Tree
clk: mvebu: armada-375: Fix the description of the SAR in the comment
arch/arm/boot/dts/armada-370.dtsi | 4 ++
drivers/clk/mvebu/armada-370.c | 8 ++++
drivers/clk/mvebu/armada-375.c | 4 +-
drivers/clk/mvebu/common.c | 82 +++++++++++++++++++++++++++++++++++++++
drivers/clk/mvebu/common.h | 7 ++++
5 files changed, 103 insertions(+), 2 deletions(-)
--
1.9.1
next reply other threads:[~2014-09-02 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 8:15 Gregory CLEMENT [this message]
2014-09-02 8:15 ` [PATCH V2 1/4] clk: mvebu: Fix clk frequency value if SSCG is enabled Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 2/4] clk: mvebu: armada-370: Fix timer drift caused by the SSCG deviation Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 3/4] ARM: mvebu: add SSCG to Armada 370 Device Tree Gregory CLEMENT
2014-09-02 8:15 ` [PATCH V2 4/4] clk: mvebu: armada-375: Fix the description of the SAR in the comment Gregory CLEMENT
2014-09-03 14:40 ` [PATCH V2 0/4] clk: mvebu: Improve clock drift Leigh Brown
2014-09-03 17:03 ` Mike Turquette
2014-09-03 17:11 ` Jason Cooper
2014-09-09 15:42 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409645719-20003-1-git-send-email-gregory.clement@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arno@natisbad.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=leigh@solinno.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ml-arm@syscall.eu \
--cc=mturquette@linaro.org \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=simon.boulay@vitec.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®