From: Joe Perches <joe@perches.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Bogus error in checkpatch.pl
Date: Tue, 02 Sep 2014 22:34:30 -0700 [thread overview]
Message-ID: <1409722470.2715.5.camel@joe-AO725> (raw)
In-Reply-To: <CAJhHMCBuUvSb46Q+kvryv2vu=1Pjq8odSs6u7P1h3HyG21k2AA@mail.gmail.com>
On Wed, 2014-09-03 at 00:29 -0400, Pranith Kumar wrote:
> Hi Joe,
Hello Pranith.
> On Wed, Sep 3, 2014 at 12:25 AM, Joe Perches <joe@perches.com> wrote:
> > You need to use parentheses around the description like:
> > commit <commitid> ("commit description")
> > For your case:
> > Commit 615cc2c9cf95 ("Documentation/memory-barriers.txt: fix important
> > typo re memory barriers")
> Ah, OK. But the error message does not say anything about missing
> paranetheses and only stresses on chars in the id:
>
> $ ./scripts/checkpatch.pl
> patch_dir/0001-doc-memory-barriers.txt-Correct-example-for-reorderi.patch
> ERROR: Please use 12 or more chars for the git commit ID like: 'Commit
> 615cc2c9cf95 ("Documentation/memory-barriers.txt: fix important typo
> re memory barriers")'
> #8:
> Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re
> Is it possible to make it a bit clearer, perhaps?
Maybe. Suggest a modified message.
next prev parent reply other threads:[~2014-09-03 5:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 4:03 Pranith Kumar
2014-09-03 4:25 ` Joe Perches
2014-09-03 4:29 ` Pranith Kumar
2014-09-03 5:34 ` Joe Perches [this message]
2014-09-03 15:09 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409722470.2715.5.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®