mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gioh Kim <gioh.kim@lge.com>
To: gioh.kim@lge.com, akpm@linux-foundation.org, jack@suse.cz,
	tytso@mit.edu, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	viro@zeniv.linux.org.uk, paulmck@linux.vnet.ibm.com,
	peterz@infradead.org, adilger.kernel@dilger.ca
Cc: minchan@kernel.org, js1304@gmail.com, gunho.lee@lge.com
Subject: [PATCHv4 2/3] ext4: use non-movable memory for the ext4 superblock
Date: Thu,  4 Sep 2014 16:29:40 +0900	[thread overview]
Message-ID: <1409815781-28011-3-git-send-email-gioh.kim@lge.com> (raw)
In-Reply-To: <1409815781-28011-1-git-send-email-gioh.kim@lge.com>

A buffer-cache for superblock is disturbing page migration,
because the buffer-cache is not released until unmount.
The buffer-cache must be allocated from non-movable area.

Signed-off-by: Gioh Kim <gioh.kim@lge.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/super.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 32b43ad..e4b62b3 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3435,7 +3435,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 		logical_sb_block = sb_block;
 	}
 
-	if (!(bh = sb_bread(sb, logical_sb_block))) {
+	if (!(bh = sb_bread_unmovable(sb, logical_sb_block))) {
 		ext4_msg(sb, KERN_ERR, "unable to read superblock");
 		goto out_fail;
 	}
@@ -3645,7 +3645,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 		brelse(bh);
 		logical_sb_block = sb_block * EXT4_MIN_BLOCK_SIZE;
 		offset = do_div(logical_sb_block, blocksize);
-		bh = sb_bread(sb, logical_sb_block);
+		bh = sb_bread_unmovable(sb, logical_sb_block);
 		if (!bh) {
 			ext4_msg(sb, KERN_ERR,
 			       "Can't read superblock on 2nd try");
@@ -3867,7 +3867,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 
 	for (i = 0; i < db_count; i++) {
 		block = descriptor_loc(sb, logical_sb_block, i);
-		sbi->s_group_desc[i] = sb_bread(sb, block);
+		sbi->s_group_desc[i] = sb_bread_unmovable(sb, block);
 		if (!sbi->s_group_desc[i]) {
 			ext4_msg(sb, KERN_ERR,
 			       "can't read group descriptor %d", i);
-- 
1.7.9.5


  parent reply	other threads:[~2014-09-04  7:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04  7:29 [PATCHv4 0/3] new APIs to allocate buffer-cache with user specific flag Gioh Kim
2014-09-04  7:29 ` [PATCHv4 1/3] fs.c: support buffer cache allocations with gfp modifiers Gioh Kim
2014-09-05  2:37   ` Theodore Ts'o
2014-09-04  7:29 ` Gioh Kim [this message]
2014-09-05  2:37   ` [PATCHv4 2/3] ext4: use non-movable memory for the ext4 superblock Theodore Ts'o
2014-09-04  7:29 ` [PATCHv4 3/3] jbd/jbd2: use non-movable memory for the jbd superblock Gioh Kim
2014-09-05  2:37   ` Theodore Ts'o
2014-09-04 22:16 ` [PATCHv4 0/3] new APIs to allocate buffer-cache with user specific flag Andrew Morton
2014-09-05  0:37   ` Gioh Kim
2014-09-05  1:14     ` Theodore Ts'o
2014-09-05  1:48       ` Joonsoo Kim
2014-09-05  3:17         ` Theodore Ts'o
2014-09-05  7:32           ` Joonsoo Kim
2014-09-05 14:14             ` Theodore Ts'o
2014-09-15  1:10               ` Joonsoo Kim
2014-09-15  6:37                 ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409815781-28011-3-git-send-email-gioh.kim@lge.com \
    --to=gioh.kim@lge.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=gunho.lee@lge.com \
    --cc=jack@suse.cz \
    --cc=js1304@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®