From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Helge Deller <deller@gmx.de>,
Ingo Tuchscherer <ingo.tuchscherer@de.ibm.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Marek Vasut <marex@denx.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
Benjamin Romer <benjamin.romer@unisys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v4 11/12] kmemleak: use seq_hex_dump() to dump buffers
Date: Thu, 4 Sep 2014 17:26:58 +0300 [thread overview]
Message-ID: <1409840819-18976-12-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1409840819-18976-1-git-send-email-andriy.shevchenko@linux.intel.com>
Instead of custom approach let's use recently introduced seq_hex_dump() helper.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
mm/kmemleak.c | 21 ++++++---------------
1 file changed, 6 insertions(+), 15 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 3cda50c..bc14fdc 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -291,23 +291,14 @@ static void hex_dump_object(struct seq_file *seq,
struct kmemleak_object *object)
{
const u8 *ptr = (const u8 *)object->pointer;
- int i, len, remaining;
- unsigned char linebuf[HEX_ROW_SIZE * 5];
+ size_t len;
/* limit the number of lines to HEX_MAX_LINES */
- remaining = len =
- min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE));
-
- seq_printf(seq, " hex dump (first %d bytes):\n", len);
- for (i = 0; i < len; i += HEX_ROW_SIZE) {
- int linelen = min(remaining, HEX_ROW_SIZE);
-
- remaining -= HEX_ROW_SIZE;
- hex_dump_to_buffer(ptr + i, linelen, HEX_ROW_SIZE,
- HEX_GROUP_SIZE, linebuf, sizeof(linebuf),
- HEX_ASCII);
- seq_printf(seq, " %s\n", linebuf);
- }
+ len = min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE));
+
+ seq_printf(seq, " hex dump (first %zu bytes):\n", len);
+ seq_hex_dump(seq, " ", DUMP_PREFIX_NONE, HEX_ROW_SIZE,
+ HEX_GROUP_SIZE, ptr, len, HEX_ASCII);
}
/*
--
2.1.0
next prev parent reply other threads:[~2014-09-04 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:26 [PATCH v4 00/12] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 01/12] hexdump: introduce test suite Andy Shevchenko
2014-09-05 9:37 ` Geert Uytterhoeven
2014-09-05 12:39 ` Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 02/12] hexdump: fix ascii column for the tail of a dump Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 03/12] hexdump: do few calculations ahead Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 04/12] hexdump: makes it return amount of bytes placed in buffer Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 05/12] seq_file: provide an analogue of print_hex_dump() Andy Shevchenko
2014-09-16 7:11 ` Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 06/12] saa7164: convert to seq_hex_dump() Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 07/12] crypto: qat - use seq_hex_dump() to dump buffers Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 08/12] parisc: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 09/12] [S390] zcrypt: " Andy Shevchenko
2014-09-04 14:26 ` [PATCH v4 10/12] staging: unisys: " Andy Shevchenko
2014-09-04 14:26 ` Andy Shevchenko [this message]
2014-09-04 14:26 ` [PATCH v4 12/12] wil6210: " Andy Shevchenko
2014-10-22 15:48 ` [PATCH v4 00/12] fs/seq_file: introduce seq_hex_dump() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409840819-18976-12-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.romer@unisys.com \
--cc=catalin.marinas@arm.com \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=herbert@gondor.apana.org.au \
--cc=ingo.tuchscherer@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=marex@denx.de \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=rdunlap@infradead.org \
--cc=tadeusz.struk@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome