From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495AbaIDO1l (ORCPT ); Thu, 4 Sep 2014 10:27:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:61391 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbaIDO1h (ORCPT ); Thu, 4 Sep 2014 10:27:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,466,1406617200"; d="scan'208";a="586257621" From: Andy Shevchenko To: Tadeusz Struk , Herbert Xu , Mauro Carvalho Chehab , Helge Deller , Ingo Tuchscherer , Alexander Viro , linux-kernel@vger.kernel.org, Joe Perches , Marek Vasut , Geert Uytterhoeven , Vladimir Kondratiev , Benjamin Romer , Catalin Marinas , Randy Dunlap Cc: Andy Shevchenko Subject: [PATCH v4 06/12] saa7164: convert to seq_hex_dump() Date: Thu, 4 Sep 2014 17:26:53 +0300 Message-Id: <1409840819-18976-7-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1409840819-18976-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1409840819-18976-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of custom approach let's use recently added seq_hex_dump() helper. Signed-off-by: Andy Shevchenko Reviewed-by: Steven Toth Acked-by: Mauro Carvalho Chehab --- drivers/media/pci/saa7164/saa7164-core.c | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c index 1bf0697..6f81584 100644 --- a/drivers/media/pci/saa7164/saa7164-core.c +++ b/drivers/media/pci/saa7164/saa7164-core.c @@ -1065,7 +1065,6 @@ static int saa7164_proc_show(struct seq_file *m, void *v) struct saa7164_dev *dev; struct tmComResBusInfo *b; struct list_head *list; - int i, c; if (saa7164_devcount == 0) return 0; @@ -1089,35 +1088,13 @@ static int saa7164_proc_show(struct seq_file *m, void *v) seq_printf(m, " .m_pdwGetReadPos = 0x%x (0x%08x)\n", b->m_dwGetWritePos, saa7164_readl(b->m_dwGetWritePos)); - c = 0; seq_printf(m, "\n Set Ring:\n"); - seq_printf(m, "\n addr 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n"); - for (i = 0; i < b->m_dwSizeSetRing; i++) { - if (c == 0) - seq_printf(m, " %04x:", i); + seq_hex_dump(m, " ", DUMP_PREFIX_OFFSET, 16, 1, + b->m_pdwSetRing, b->m_dwSizeSetRing, false); - seq_printf(m, " %02x", *(b->m_pdwSetRing + i)); - - if (++c == 16) { - seq_printf(m, "\n"); - c = 0; - } - } - - c = 0; seq_printf(m, "\n Get Ring:\n"); - seq_printf(m, "\n addr 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f\n"); - for (i = 0; i < b->m_dwSizeGetRing; i++) { - if (c == 0) - seq_printf(m, " %04x:", i); - - seq_printf(m, " %02x", *(b->m_pdwGetRing + i)); - - if (++c == 16) { - seq_printf(m, "\n"); - c = 0; - } - } + seq_hex_dump(m, " ", DUMP_PREFIX_OFFSET, 16, 1, + b->m_pdwGetRing, b->m_dwSizeGetRing, false); mutex_unlock(&b->lock); -- 2.1.0