mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	eranian@google.com, tglx@linutronix.de,
	Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 5/5] perf, x86, uncore: Fix PCU filter setup for Sandy/Ivy/Haswell EP
Date: Thu,  4 Sep 2014 16:08:29 -0700	[thread overview]
Message-ID: <1409872109-31645-5-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1409872109-31645-1-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

The PCU frequency band filters use 8 bit each in a register.
When setting up the value the shift value was not correctly
scaled, which resulted in all filters except for band 0 to
be zero. Fix the scaling.

This allows to correctly monitor multiple uncore frequency bands.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c b/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
index b237abc2..adf138e 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
@@ -841,7 +841,7 @@ static int snbep_pcu_hw_config(struct intel_uncore_box *box, struct perf_event *
 	if (ev_sel >= 0xb && ev_sel <= 0xe) {
 		reg1->reg = SNBEP_PCU_MSR_PMON_BOX_FILTER;
 		reg1->idx = ev_sel - 0xb;
-		reg1->config = event->attr.config1 & (0xff << reg1->idx);
+		reg1->config = event->attr.config1 & (0xff << (reg1->idx * 8));
 	}
 	return 0;
 }
-- 
1.9.3


  parent reply	other threads:[~2014-09-04 23:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 23:08 [PATCH 1/5] perf, x86, uncore: Fix section mismatch in split uncore driver Andi Kleen
2014-09-04 23:08 ` [PATCH 2/5] perf, x86, uncore: Add Haswell-EP uncore support Andi Kleen
2014-09-24 15:00   ` [tip:perf/core] perf/x86/intel/uncore: " tip-bot for Yan, Zheng
2014-10-22 19:07   ` [PATCH 2/5] perf, x86, uncore: " Alexei Starovoitov
2014-10-27 11:57     ` Andi Kleen
2014-09-04 23:08 ` [PATCH 3/5] perf, x86, uncore: Register the PMU only if the uncore pci device exists Andi Kleen
2014-09-24 15:00   ` [tip:perf/core] perf/x86/intel/uncore: " tip-bot for Yan, Zheng
2014-09-04 23:08 ` [PATCH 4/5] perf, x86, uncore: Add missing cbox filter flags on IvyBridge-EP uncore driver Andi Kleen
2014-09-24 15:00   ` [tip:perf/core] perf/x86/intel/uncore: " tip-bot for Andi Kleen
2014-09-04 23:08 ` Andi Kleen [this message]
2014-09-24 15:00   ` [tip:perf/core] perf/x86/intel/uncore: Fix PCU filter setup for Sandy/Ivy/Haswell EP tip-bot for Andi Kleen
2014-09-19  0:44 ` [PATCH 1/5] perf, x86, uncore: Fix section mismatch in split uncore driver Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409872109-31645-5-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®