mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ted Percival <ted@tedp.id.au>
To: Christoph Lameter <cl@linux.com>, Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Ted Percival <ted@tedp.id.au>
Subject: [PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask
Date: Fri, 5 Sep 2014 14:18:19 -0600	[thread overview]
Message-ID: <1409948299-6547-1-git-send-email-ted@tedp.id.au> (raw)
In-Reply-To: <540A192D.9020400@tedp.id.au>

This fixes a hang when initializing SMP CPUs at this point in the boot:

x86: Booting SMP configuration
.... node  #0, CPUs:      #1_

Fixes: 4ba2968420fa ("percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t")
Signed-off-by: Ted Percival <ted@tedp.id.au>
---
 arch/x86/kernel/apic/x2apic_cluster.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2ffae6..e658f21681c8 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
 	 * and be sure it's manipulated with irq off.
 	 */
 	ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+	cpumask_copy(ipi_mask_ptr, mask);
 
 	/*
 	 * The idea is to send one IPI per cluster.
-- 
1.9.1


      reply	other threads:[~2014-09-05 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 19:34 Ted Percival
2014-09-05 20:12 ` Ted Percival
2014-09-05 20:18   ` Ted Percival [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409948299-6547-1-git-send-email-ted@tedp.id.au \
    --to=ted@tedp.id.au \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®