mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: linux-kernel@vger.kernel.org,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Sasha Levin <sasha.levin@oracle.com>,
	akpm@linuxfoundation.org, mingo@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Richard Weinberger <richard.weinberger@gmail.com>
Subject: Re: [PATCH] gcc: clamp gcc version to most highest specific header version available
Date: Fri, 05 Sep 2014 14:09:24 -0700	[thread overview]
Message-ID: <1409951364.2618.28.camel@joe-AO725> (raw)
In-Reply-To: <8bf23840962ec5a33b1bfae7fdf8b0a0f94c4227.1409949573.git.hannes@stressinduktion.org>

On Fri, 2014-09-05 at 22:39 +0200, Hannes Frederic Sowa wrote:
> As announced in [1] gcc will increase its major number yearly but we don't
> need to include gcc version specific quirks for every version normally.
> 
> This patch allows to compile every kernel with all new versions of gcc
> without adding a specific compiler-gccX.h header. We do so by clamping
> the __GNUC__ version to the most specific version dependent header file.
> 
> If someone adds a new gccX.h file __GCC_CLAMP_VERSION_HEADER also needs
> to be modified.
> 
> The decision if chained including of header files (e.g. gcc5.h includes
> gcc4.h) is necessary or should be avoided can be postponed until more
> experience in using the official gcc release is gained.

I think the churn rate in the gcc compiler specific
#include headers will be low enough that a single
combined file should be acceptable.

Keeping all the gcc #defines together seems more
readable to me.

The trivial integration I did eliminated one
duplicate #define as well as that hack for
#include gcc_header(__GNUC__)





  reply	other threads:[~2014-09-05 21:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 15:37 [PATCH] kernel: add support for gcc 5 Sasha Levin
2014-09-04 21:12 ` Andrew Morton
2014-09-04 21:19   ` Richard Weinberger
2014-09-04 21:25     ` Andrew Morton
2014-09-04 21:38       ` Sasha Levin
2014-09-05 15:04       ` H. Peter Anvin
2014-09-04 21:25 ` Aaro Koskinen
2014-09-04 21:32   ` Sasha Levin
2014-09-04 22:43   ` Hannes Frederic Sowa
2014-09-04 23:47     ` Joe Perches
2014-09-05  3:37       ` Sasha Levin
2014-09-05  3:58         ` Joe Perches
2014-09-05  4:08         ` Hannes Frederic Sowa
2014-09-05 14:44           ` Sasha Levin
2014-09-05 20:39             ` [PATCH] gcc: clamp gcc version to most highest specific header version available Hannes Frederic Sowa
2014-09-05 21:09               ` Joe Perches [this message]
2014-09-05 22:38                 ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409951364.2618.28.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=akpm@linuxfoundation.org \
    --cc=hannes@stressinduktion.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=richard.weinberger@gmail.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®