From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F741F7916 for ; Fri, 6 Mar 2026 11:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772796807; cv=none; b=PIIjDOT7L7RbMlT/YkI9IDZgxV9PHteYtRuudRNS59N6iDgmYEdb6V02kBaL34INwakTnVp+iXJYGyBvdZQQZDZFBhHQ6Z8Dm2jAyeY1NI1qxw/OfjS00MN4RFnr+z8nljt+UGGunqDt51Rmem3kJ4J65SPMhQjaC/taA1kCu9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772796807; c=relaxed/simple; bh=RBbtaeJIVRam9A0+0nEw15ZQ/vsFL4LW5MRLADGKFcY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f0VyXBSo3XV6RBxvREEDhonTC5aQaCPQgsit+d9RrhUQazQTkBxr8B4kKn1gg9zOBPcGtZKfIv7jAeHSo+1zWWdqXmN9HgFkWtcA/JdeuMg30AkZoYTWsF5gSJ8E6rBR6knOyKmapH71R1UXDijIdMG3rcUuaYo5olO1yDRVoN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=No69KQPL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="No69KQPL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F806C2BC87; Fri, 6 Mar 2026 11:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772796807; bh=RBbtaeJIVRam9A0+0nEw15ZQ/vsFL4LW5MRLADGKFcY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=No69KQPLwYkjO7WvUawTvr+cGDC9dvQUHAODxK1fvdChKkJg0ByANlrCS3moc9wJx zxDxk3btlwmpztOa/LgOuCV8pxelUcKyyi/4NjIfaZssSYNfE3upqZ8Mv1rPcxidf4 bsrkdZjpT8TvNa0+voc/8Y7UzgrWnDHZ3PPKtQMlq1+x+JaJHgLECqaSLROwOG5dw4 n798AW/y38bP+bRv7K4VNnHQMGm2/QXLEbeTLGzrqNCOuA04W5n/hGQrgzI0V4PjXv yOvKFS7J/FrayJJBKVc0+jpzUp80k+BK6YPrZAo/QDmwcudV/xB/kgftokNnChnWQE r9i3y6MirgAog== Date: Fri, 6 Mar 2026 11:33:24 +0000 From: "Lorenzo Stoakes (Oracle)" To: Breno Leitao Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 1/3] mm: khugepaged: export set_recommended_min_free_kbytes() Message-ID: <140d8a35-8c29-42ad-aa8f-e048bdf59f03@lucifer.local> References: <20260305-thp_logs-v2-0-96b3ad795894@debian.org> <20260305-thp_logs-v2-1-96b3ad795894@debian.org> <043071c6-08d0-4618-9a9d-196ccf1caab1@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <043071c6-08d0-4618-9a9d-196ccf1caab1@lucifer.local> On Fri, Mar 06, 2026 at 11:20:57AM +0000, Lorenzo Stoakes (Oracle) wrote: > > include/linux/khugepaged.h | 1 + > > mm/khugepaged.c | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/khugepaged.h b/include/linux/khugepaged.h > > index d7a9053ff4fed..76252865fca4b 100644 > > --- a/include/linux/khugepaged.h > > +++ b/include/linux/khugepaged.h > > @@ -16,6 +16,7 @@ extern void __khugepaged_exit(struct mm_struct *mm); > > extern void khugepaged_enter_vma(struct vm_area_struct *vma, > > vm_flags_t vm_flags); > > extern void khugepaged_min_free_kbytes_update(void); > > +extern void set_recommended_min_free_kbytes(void); > > Please drop the extern, it's a historic artifact that we clean up when we add > new entries (I don't blame you for including it, it's a sort of 'unwritten' > convention :P) Oh, and with that fixed, feel free to add: Reviewed-by: Lorenzo Stoakes (Oracle) To this patch on respin. Cheers, Lorenzo