From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f0.google.com (mail-wr2-f0.google.com [74.125.225.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04998422522 for ; Mon, 17 Aug 2026 16:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786985265; cv=none; b=tkxNwikzHh4Hk4wc4b65k3Q6Iak7bflDq8tM0aVQ6M7m6zjjdHG2I6EufemSRo0/CtC5FdzHYfUrZooupk5TX6/d641ECL+XHX7XuDdDZmlogZpvF5TcKU7oQ2hjlK/830AXVEfX894tNv6poJBUjZCnTNQwBq+M8CRqVBjaXv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786985265; c=relaxed/simple; bh=S0YihGns/HogDj6mdTaYduxc4sX4rOFFjlMglxenAsI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZIDWncjwyMHWHHT/awtqt6/lCexSMo82D5ciy2PX2YmsiLBMNLqtalBxM0juUT2uNtl9Rv/MjTDVPrB7NqXVVOq3V7JMKyQQYglpXDTbJWWsy9rcRkJ0lwNyB7ovrdlAi5Xivt0QCcwTTq4rnlpwp1+iJQnbavSHUjUYerDAdTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=74.125.225.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr2-f0.google.com with SMTP id ffacd0b85a97d-4784b41f3aeso892814f8f.1 for ; Mon, 17 Aug 2026 09:47:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786985262; x=1787590062; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W2f8MmagPFbk9XG5LRo+qCezm6yoGph0yYValvhduB4=; b=dMVwuYjOt95GBeehUf1Y1XZ+ss3uOPhWvyqrSNk1QpQsbpBHp3ynqxenBk+H3s5tVy UirDfCgmFtco6ry6+9QDfr2Ts7pOvT1y1g26sFJhhIDTyTR+jQiEaA0pPNYaFIFwT4qU xXdUah0I5UzoIo9G0aaXlxXKLGOyUHuU7oulczFE0lANSKqkNQRZekjWXzs//aSlV5pb nIY9vVpQP4U30H0Ut1L7r5p9+epuS5IAOUq+rKZJGMbcuv9kw/y6NH6/dmVC0SuPX/2g xM4GuwyBi90VtXxK8OdpjEBBvcjsR5PCVaF48PT3uycVQ3pOu2O+cC9NkiAEyxR22d6M 9H+w== X-Forwarded-Encrypted: i=1; AHgh+RrcqQpEtAZ6BxULAvqn93nWxxifnKOVeXyVAa67lPGualQ/pWX+ZSxS77wSnfugMkIkP/+Jy5inkdOOIa8=@vger.kernel.org X-Gm-Message-State: AOJu0YxbRR2npd7H+eVD0N5HphDkRromq5sdAusyDqzu1oMn9ukrzYlY sN1XhlUWn72/w1rqjwesD7XDYlPMP/q3+2rIdFUkxGZPOgATUnc0W/gY X-Gm-Gg: AR+sD101xsx+KmWeGpo/LIQmqVeItdLOY6NJiGR0Y4nqMfAmbRSGj4ywJM4m+q6oRwU CJKip1cVv/HWhNGOIb4cf3ScD4E6Ro9ACtowQPlrd6e3wRdapvtkUWNgrmnvHrmb4bwk7QklGnS g9JvIsnHfgaPDCq540oHuBoNPygqrX8jaRKKutne5Gs2/tY8IQjU+LvbOtaGACQVaW5QSHK8tx9 BMsT+odzgkp0La+OoGYrE2OpQsN8MOu/eNv3U8RtrHPqdxFZy51NqUnoGZv4ENvxUqYjFRI1+rp 8UmYBXO+Jh+GAfmi7AHYwF810oQRvWODJ6cCLsyScEl6NyyRIoaRXwQKiFD9wf8ODqkTnEXim3v rJC9QTu8eTgRfuxmJdyc3gx0z22L1tqGUAOe6mS8LD2eDCu/KUh814iRJ17CgCC4cgkcjn2fzcV RwA3TpDMPiGaey03c633nhI588FJQCwyF2/1feGbCTJyHXSWALNa34c/YAv8KG3q0Ymy6OQxwhF 2ICq8JMAZTsijnvWh0y4m4QFAeG X-Received: by 2002:a5d:5449:0:b0:47f:5369:bba with SMTP id ffacd0b85a97d-48160782d05mr38208457f8f.15.1786985261898; Mon, 17 Aug 2026 09:47:41 -0700 (PDT) Received: from [192.168.88.241] (89-24-57-65.nat.epc.tmcz.cz. [89.24.57.65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b81715sm5288916f8f.35.2026.08.17.09.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 09:47:41 -0700 (PDT) Message-ID: <140da5e6-15eb-45be-813f-ee5629b64ba1@ovn.org> Date: Mon, 17 Aug 2026 18:47:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 3/3] net: skbuff: don't touch shared zerocopy state in skb_tx_error() To: Norbert Szetei , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Aaron Conole , Eelco Chaudron , linux-kernel@vger.kernel.org, dev@openvswitch.org, i.maximets@ovn.org References: Content-Language: en-US From: Ilya Maximets Autocrypt: addr=i.maximets@ovn.org; keydata= xsFNBF77bOMBEADVZQ4iajIECGfH3hpQMQjhIQlyKX4hIB3OccKl5XvB/JqVPJWuZQRuqNQG /B70MP6km95KnWLZ4H1/5YOJK2l7VN7nO+tyF+I+srcKq8Ai6S3vyiP9zPCrZkYvhqChNOCF pNqdWBEmTvLZeVPmfdrjmzCLXVLi5De9HpIZQFg/Ztgj1AZENNQjYjtDdObMHuJQNJ6ubPIW cvOOn4WBr8NsP4a2OuHSTdVyAJwcDhu+WrS/Bj3KlQXIdPv3Zm5x9u/56NmCn1tSkLrEgi0i /nJNeH5QhPdYGtNzPixKgPmCKz54/LDxU61AmBvyRve+U80ukS+5vWk8zvnCGvL0ms7kx5sA tETpbKEV3d7CB3sQEym8B8gl0Ux9KzGp5lbhxxO995KWzZWWokVUcevGBKsAx4a/C0wTVOpP FbQsq6xEpTKBZwlCpxyJi3/PbZQJ95T8Uw6tlJkPmNx8CasiqNy2872gD1nN/WOP8m+cIQNu o6NOiz6VzNcowhEihE8Nkw9V+zfCxC8SzSBuYCiVX6FpgKzY/Tx+v2uO4f/8FoZj2trzXdLk BaIiyqnE0mtmTQE8jRa29qdh+s5DNArYAchJdeKuLQYnxy+9U1SMMzJoNUX5uRy6/3KrMoC/ 7zhn44x77gSoe7XVM6mr/mK+ViVB7v9JfqlZuiHDkJnS3yxKPwARAQABzSJJbHlhIE1heGlt ZXRzIDxpLm1heGltZXRzQG92bi5vcmc+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAFiEEh+ma1RKWrHCY821auffsd8gpv5YFAmfB9JAFCQyI7q0ACgkQuffsd8gpv5YQ og/8DXt1UOznvjdXRHVydbU6Ws+1iUrxlwnFH4WckoFgH4jAabt25yTa1Z4YX8Vz0mbRhTPX M/j1uORyObLem3of4YCd4ymh7nSu++KdKnNsZVHxMcoiic9ILPIaWYa8kTvyIDT2AEVfn9M+ vskM0yDbKa6TAHgr/0jCxbS+mvN0ZzDuR/LHTgy3e58097SWJohj0h3Dpu+XfuNiZCLCZ1/G AbBCPMw+r7baH/0evkX33RCBZwvh6tKu+rCatVGk72qRYNLCwF0YcGuNBsJiN9Aa/7ipkrA7 Xp7YvY3Y1OrKnQfdjp3mSXmknqPtwqnWzXvdfkWkZKShu0xSk+AjdFWCV3NOzQaH3CJ67NXm aPjJCIykoTOoQ7eEP6+m3WcgpRVkn9bGK9ng03MLSymTPmdINhC5pjOqBP7hLqYi89GN0MIT Ly2zD4m/8T8wPV9yo7GRk4kkwD0yN05PV2IzJECdOXSSStsf5JWObTwzhKyXJxQE+Kb67Wwa LYJgltFjpByF5GEO4Xe7iYTjwEoSSOfaR0kokUVM9pxIkZlzG1mwiytPadBt+VcmPQWcO5pi WxUI7biRYt4aLriuKeRpk94ai9+52KAk7Lz3KUWoyRwdZINqkI/aDZL6meWmcrOJWCUMW73e 4cMqK5XFnGqolhK4RQu+8IHkSXtmWui7LUeEvO/OwU0EXvts4wEQANCXyDOic0j2QKeyj/ga OD1oKl44JQfOgcyLVDZGYyEnyl6b/tV1mNb57y/YQYr33fwMS1hMj9eqY6tlMTNz+ciGZZWV YkPNHA+aFuPTzCLrapLiz829M5LctB2448bsgxFq0TPrr5KYx6AkuWzOVq/X5wYEM6djbWLc VWgJ3o0QBOI4/uB89xTf7mgcIcbwEf6yb/86Cs+jaHcUtJcLsVuzW5RVMVf9F+Sf/b98Lzrr 2/mIB7clOXZJSgtV79Alxym4H0cEZabwiXnigjjsLsp4ojhGgakgCwftLkhAnQT3oBLH/6ix 87ahawG3qlyIB8ZZKHsvTxbWte6c6xE5dmmLIDN44SajAdmjt1i7SbAwFIFjuFJGpsnfdQv1 OiIVzJ44kdRJG8kQWPPua/k+AtwJt/gjCxv5p8sKVXTNtIP/sd3EMs2xwbF8McebLE9JCDQ1 RXVHceAmPWVCq3WrFuX9dSlgf3RWTqNiWZC0a8Hn6fNDp26TzLbdo9mnxbU4I/3BbcAJZI9p 9ELaE9rw3LU8esKqRIfaZqPtrdm1C+e5gZa2gkmEzG+WEsS0MKtJyOFnuglGl1ZBxR1uFvbU VXhewCNoviXxkkPk/DanIgYB1nUtkPC+BHkJJYCyf9Kfl33s/bai34aaxkGXqpKv+CInARg3 fCikcHzYYWKaXS6HABEBAAHCwXwEGAEIACYCGwwWIQSH6ZrVEpascJjzbVq59+x3yCm/lgUC Z8H0qQUJDIjuxgAKCRC59+x3yCm/loAdD/wJCOhPp9711J18B9c4f+eNAk5vrC9Cj3RyOusH Hebb9HtSFm155Zz3xiizw70MSyOVikjbTocFAJo5VhkyuN0QJIP678SWzriwym+EG0B5P97h FSLBlRsTi4KD8f1Ll3OT03lD3o/5Qt37zFgD4mCD6OxAShPxhI3gkVHBuA0GxF01MadJEjMu jWgZoj75rCLG9sC6L4r28GEGqUFlTKjseYehLw0s3iR53LxS7HfJVHcFBX3rUcKFJBhuO6Ha /GggRvTbn3PXxR5UIgiBMjUlqxzYH4fe7pYR7z1m4nQcaFWW+JhY/BYHJyMGLfnqTn1FsIwP dbhEjYbFnJE9Vzvf+RJcRQVyLDn/TfWbETf0bLGHeF2GUPvNXYEu7oKddvnUvJK5U/BuwQXy TRFbae4Ie96QMcPBL9ZLX8M2K4XUydZBeHw+9lP1J6NJrQiX7MzexpkKNy4ukDzPrRE/ruui yWOKeCw9bCZX4a/uFw77TZMEq3upjeq21oi6NMTwvvWWMYuEKNi0340yZRrBdcDhbXkl9x/o skB2IbnvSB8iikbPng1ihCTXpA2yxioUQ96Akb+WEGopPWzlxTTK+T03G2ljOtspjZXKuywV Wu/eHyqHMyTu8UVcMRR44ki8wam0LMs+fH4dRxw5ck69AkV+JsYQVfI7tdOu7+r465LUfg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/16/26 8:57 AM, Norbert Szetei wrote: > skb_tx_error() completes the zerocopy uarg and clears > SKBFL_ALL_ZEROCOPY, and skb_zcopy_downgrade_managed() clears > SKBFL_MANAGED_FRAG_REFS. Both live in skb_shinfo(), which every clone > shares, while the caller only owns the reference it is about to drop. > Through a clone it tells the producer its pages are free and drops > SKBFL_SHARED_FRAG for an skb that is still in flight. > > Open vSwitch reaches this with a non-last OVS_ACTION_ATTR_RECIRC: > clone_execute() sends a skb_clone() into ovs_dp_process_packet() while > do_execute_actions() keeps forwarding the original, and skb_clone() > does not privatise the frags here -- skb_orphan_frags() returns early > on SKBFL_DONT_ORPHAN. A flow miss on the clone then strips the marker > from the packet still being forwarded, and a later local ESP delivery > decrypts in place over frags it does not own privately. > > Skip it for a cloned skb. Nothing is lost: skb_release_data() clears > the zerocopy state once the last reference to the shared data goes. > > Fixes: 36d5fe6a0007 ("core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors") I think, this should be 25121173f7b1 ("skb: api to report errors for zero copy skbs") instead. Otherwise, LGTM. Also, please, add all maintainers as per get_maintainers script into CC while sending patches (may drop Zoltan though, since his email bounced, as well as Pravin). Note: there is a conflict between this set and the https://lore.kernel.org/r/20260814191336.187243-1-almasrymina@google.com But I think, it's better if we apply the tx_error fixes first, as they need to be backported further. Best regards, Ilya Maximets. > Fixes: f4c50a4034e6 ("xfrm: esp: avoid in-place decrypt on shared skb frags") > Cc: stable@vger.kernel.org > Suggested-by: Ilya Maximets > Signed-off-by: Norbert Szetei > --- > net/core/skbuff.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index db62ed6e04b9..04776a112334 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -1417,10 +1417,13 @@ EXPORT_SYMBOL(skb_dump); > * > * Report xmit error if a device callback is tracking this skb. > * skb must be freed afterwards. > + * > + * Does nothing for a cloned skb: the zerocopy state lives in > + * skb_shinfo(), which the clones share. > */ > void skb_tx_error(struct sk_buff *skb) > { > - if (skb) { > + if (skb && !skb_cloned(skb)) { > skb_zcopy_downgrade_managed(skb); > skb_zcopy_clear(skb, true); > }