From: Randy Dunlap <rdunlap@infradead.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Tomer Maimon <tmaimon77@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: nuvoton: Fix up Kconfig deps
Date: Wed, 13 Sep 2023 10:12:44 -0700 [thread overview]
Message-ID: <140e7f79-4e03-47ec-99de-90871ca8d445@infradead.org> (raw)
In-Reply-To: <20230913-novoton-kconfig-v1-1-1c2dff14c0d2@linaro.org>
On 9/13/23 01:50, Linus Walleij wrote:
> We have build errors due to missing dependency on OF.
> Add the dependency and do it the same way for all three
> Nuvotons while we are at it.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/pinctrl/nuvoton/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 612e7ba02238..2abbfcec1fae 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -2,8 +2,7 @@
>
> config PINCTRL_WPCM450
> tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
> - depends on ARCH_WPCM450 || COMPILE_TEST
> - depends on OF
> + depends on (ARCH_WPCM450 || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> @@ -35,7 +34,7 @@ config PINCTRL_NPCM7XX
>
> config PINCTRL_NPCM8XX
> tristate "Pinctrl and GPIO driver for Nuvoton NPCM8XX"
> - depends on ARCH_NPCM || COMPILE_TEST
> + depends on (ARCH_NPCM || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
> ---
> base-commit: c9336ebe87e77f92ed04a86c0131a0310d0e200d
> change-id: 20230913-novoton-kconfig-895c60755500
>
> Best regards,
--
~Randy
prev parent reply other threads:[~2023-09-13 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 8:50 Linus Walleij
2023-09-13 17:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140e7f79-4e03-47ec-99de-90871ca8d445@infradead.org \
--to=rdunlap@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tmaimon77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®