From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753789AbaIHM4f (ORCPT ); Mon, 8 Sep 2014 08:56:35 -0400 Received: from mga09.intel.com ([134.134.136.24]:52180 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbaIHM4e (ORCPT ); Mon, 8 Sep 2014 08:56:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,486,1406617200"; d="scan'208";a="569958418" Message-ID: <1410180990.10764.164.camel@sauron.fi.intel.com> Subject: Re: [PATCH][V2] UBI: block: fix dereference on uninitialized dev From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Colin King Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, ezequiel.garcia@free-electrons.com, linux-kernel@vger.kernel.org Date: Mon, 08 Sep 2014 15:56:30 +0300 In-Reply-To: <1408526378-12972-1-git-send-email-colin.king@canonical.com> References: <1408526378-12972-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-08-20 at 10:19 +0100, Colin King wrote: > From: Colin Ian King > > commit 4df38926f337 ("UBI: block: Avoid disk size integer overflow") > introduced a dereference on dev (which is not initialized at that > point) when printing a warning message. Re-order disk_capacity check > after the dev is found. > > Found by cppcheck: > [drivers/mtd/ubi/block.c:509]: (error) Uninitialized variable: dev Picked this one, thanks! -- Best Regards, Artem Bityutskiy