From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754505AbaIHOQm (ORCPT ); Mon, 8 Sep 2014 10:16:42 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:42402 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753034AbaIHOQk (ORCPT ); Mon, 8 Sep 2014 10:16:40 -0400 From: Dmitry Voytik To: Greg Kroah-Hartman Cc: Joe Perches , Brian Swetland , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , linux-kernel@vger.kernel.org, Dmitry Voytik Subject: [PATCH] staging: binder: fix coding style issues Date: Mon, 8 Sep 2014 18:16:34 +0400 Message-Id: <1410185794-16160-1-git-send-email-voytikd@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1410184684.12560.11.camel@joe-AO725> References: <1410184684.12560.11.camel@joe-AO725> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix coding style issues: * put braces in all if-else branches; * limit the length of changed lines to 80 columns. checkpatch.pl warning count reduces by 3. Signed-off-by: Dmitry Voytik Reviewed-by: Joe Perches --- drivers/staging/android/binder.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 4f34dc0..4f1a6f7 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -2198,12 +2198,16 @@ retry: struct binder_work *w; struct binder_transaction *t = NULL; - if (!list_empty(&thread->todo)) - w = list_first_entry(&thread->todo, struct binder_work, entry); - else if (!list_empty(&proc->todo) && wait_for_proc_work) - w = list_first_entry(&proc->todo, struct binder_work, entry); - else { - if (ptr - buffer == 4 && !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN)) /* no data added */ + if (!list_empty(&thread->todo)) { + w = list_first_entry(&thread->todo, struct binder_work, + entry); + } else if (!list_empty(&proc->todo) && wait_for_proc_work) { + w = list_first_entry(&proc->todo, struct binder_work, + entry); + } else { + /* no data added */ + if (ptr - buffer == 4 && + !(thread->looper & BINDER_LOOPER_STATE_NEED_RETURN)) goto retry; break; } -- 1.9.1