mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dmitry Voytik <voytikd@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Brian Swetland" <swetland@google.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: binder: fix coding style issues
Date: Mon, 08 Sep 2014 08:41:28 -0700	[thread overview]
Message-ID: <1410190888.12560.15.camel@joe-AO725> (raw)
In-Reply-To: <1410185794-16160-1-git-send-email-voytikd@gmail.com>

On Mon, 2014-09-08 at 18:16 +0400, Dmitry Voytik wrote:
> Fix coding style issues:
> * put braces in all if-else branches;
> * limit the length of changed lines to 80 columns.
> checkpatch.pl warning count reduces by 3.
> 
> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
> Reviewed-by: Joe Perches <joe@perches.com>

Hi Dmitry.

I don't see any defect in your patch now but here's
a bit of trivia for you.

I didn't sign anything here.

Please don't add signatures from another person unless
or until specifically written by that other person.

cheers, Joe


  reply	other threads:[~2014-09-08 15:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 13:37 Dmitry Voytik
2014-09-08 13:58 ` Joe Perches
2014-09-08 14:16   ` Dmitry Voytik
2014-09-08 15:41     ` Joe Perches [this message]
2014-09-08 18:45       ` Dmitry Voytik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410190888.12560.15.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=arve@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swetland@google.com \
    --cc=voytikd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®