mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Christopher Covington <cov@codeaurora.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Paul Mackerras <paulus@samba.org>,
	John Stultz <john.stultz@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [RFC 2/2] perf: Marker software event and ioctl
Date: Fri, 12 Sep 2014 14:58:55 +0100	[thread overview]
Message-ID: <1410530335.16936.60.camel@hornet> (raw)
In-Reply-To: <20140912134910.GG1801@kernel.org>

On Fri, 2014-09-12 at 14:49 +0100, Arnaldo Carvalho de Melo wrote:
> Perhaps both? I.e. an u64 followed from a string, if the u64 is zero,
> then there is a string right after it?

How would this look like in userspace? Something like this?

8<----
struct perf_event_marker {
	uint64_t value;
	char *string;
} arg;

arg.value = 0x1234;

/* or */

arg.value = 0;
arg.string = "abcd";

ioctl(fd, PERF_EVENT_IOC_MARKER, &arg)
8<----

If so, maybe it would simpler just to go for classic size/data
structure?

8<-----
struct perf_event_marker {
	uint32_t size;
	void *data;
}
8<-----

This would directly map into struct perf_raw_record...

Paweł


  reply	other threads:[~2014-09-12 13:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 11:48 [RFC 0/2] Yet another take at user/kernel time correlation problem Pawel Moll
2014-09-12 11:48 ` [RFC 1/2] perf: Add sampling of the raw monotonic clock Pawel Moll
2014-09-12 11:48 ` [RFC 2/2] perf: Marker software event and ioctl Pawel Moll
2014-09-12 12:43   ` Christopher Covington
2014-09-12 12:57     ` Pawel Moll
2014-09-12 13:49       ` Arnaldo Carvalho de Melo
2014-09-12 13:58         ` Pawel Moll [this message]
2014-09-12 16:19           ` Arnaldo Carvalho de Melo
2014-09-15 17:27             ` Pawel Moll
2014-09-15 18:31               ` Arnaldo Carvalho de Melo
2014-09-16 16:33                 ` Pawel Moll
2014-09-12 14:00       ` Christopher Covington
2014-09-12 17:37   ` David Ahern
2014-09-12 20:44     ` Arnaldo Carvalho de Melo
2014-09-14 15:43       ` David Ahern
2014-09-15 17:18         ` Pawel Moll
2014-09-16  7:44         ` Ingo Molnar
2014-09-16 16:37           ` Pawel Moll
2014-09-16 17:58             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410530335.16936.60.camel@hornet \
    --to=pawel.moll@arm.com \
    --cc=acme@kernel.org \
    --cc=cov@codeaurora.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=richardcochran@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome