mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: "anish kumar" <anish198519851985@gmail.com>, 최찬우 <cw00.choi@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: checkpatch warning removal
Date: Fri, 31 Aug 2012 08:13:02 +0000 (GMT)	[thread overview]
Message-ID: <14107831.94151346400781515.JavaMail.weblogic@epml19> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1337 bytes --]

> From: anish kumar <anish198519851985@gmail.com>
> 
> without this patch we get below warning:
> WARNING: externs should be avoided in .c files
> 132: FILE: extcon/extcon-class.c:
> int extcon_set_state(struct extcon_dev *edev, u32 state);
> 
> So just removed the declaration.
> 
> Signed-off-by: anish kumar <anish198519851985@gmail.com>

Ah.. yes.. I thought removing it could emit compiler errors.
But, we have it declared in the header file. Good.

Thanks.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

> ---
>  drivers/extcon/extcon-class.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index 06df95a..6f3391b 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -129,7 +129,6 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
>  	return count;
>  }
>  
> -int extcon_set_state(struct extcon_dev *edev, u32 state);
>  static ssize_t state_store(struct device *dev, struct device_attribute *attr,
>  			   const char *buf, size_t count)
>  {
> -- 
> 1.7.1
> 
> 
> 
> 
>        
>   
>          
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

             reply	other threads:[~2012-08-31  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31  8:13 MyungJoo Ham [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-30 16:31 anish kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14107831.94151346400781515.JavaMail.weblogic@epml19 \
    --to=myungjoo.ham@samsung.com \
    --cc=anish198519851985@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome