From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbaIPM7i (ORCPT ); Tue, 16 Sep 2014 08:59:38 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:62377 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbaIPM7f (ORCPT ); Tue, 16 Sep 2014 08:59:35 -0400 X-AuditID: cbfec7f5-b7f776d000003e54-88-541834355ef3 From: Krzysztof Kozlowski To: Russell King , Dan Williams , Vinod Koul , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Ulf Hansson , Grant Likely , Lars-Peter Clausen , Michal Simek , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Randy Dunlap , Alan Stern , linux-doc@vger.kernel.org, linux-pm@vger.kernel.org Cc: Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski Subject: [PATCH v5 0/4] amba/dma: pl330: add Power Management support Date: Tue, 16 Sep 2014 14:59:16 +0200 Message-id: <1410872360-27029-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t/xK7qmJhIhBj8uslhsnLGe1WL61AuM Fqun/mW1OPBnB6PF6xeGFmeb3rBbLJk8n9Vi1pS9TBYL25awWFzeNYfN4nPvEUaL25d5LdYe uctu8e5lhMXdU0fZLN7emc5iceb0JVaLCb8vsFkcXxtu8bJvP4uDiEdLcw+bx+YVWh6L97xk 8rhzbQ+bx5I3h1g9tlxtZ/GYffcHo0ffllWMHitWf2f3+LxJzmPv598sAdxRXDYpqTmZZalF +nYJXBlP248xF/wQqdh/6wVzA+NFgS5GTg4JAROJzpPHmCFsMYkL99azdTFycQgJLGWUeLJu KzOE08ck0fFhGgtIFZuAscTm5UvAqkQEjrBIPLv3BMxhFjjKKDG99y0TSJWwgKvE9t4TrCA2 i4CqxI+nd9lAbF4Bd4n/01axQeyTkzh5bDLrBEbuBYwMqxhFU0uTC4qT0nON9IoTc4tL89L1 kvNzNzFCwvvrDsalx6wOMQpwMCrx8Gb8Ew8RYk0sK67MPcQowcGsJMLroSkRIsSbklhZlVqU H19UmpNafIiRiYNTqoFRjb9M5/mW+ilRG+/v/3v5y6//riZV3zfK7G+MTKzdwv3iX/HEd8tf XlxqO6PyfbiJ1SSzA9mXbn/S/zF5q9dbO5u7R6U9BbgTd6Q65Lacne3w23s7/7e3jMW3Z2Vb 3rbrt7+z2ZP53lPNRi/R+3/mvlu0jDE1Z0HMWRGBFTJOM3KWzuvO/b3VQomlOCPRUIu5qDgR ANAbZLhNAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This is fifth version of patches adding runtime PM to the pl330 driver. The runtime PM of pl330 driver requires interrupt safe suspend/resume callbacks which is in conflict with current amba bus driver. The latter also unprepares and prepares the AMBA bus clock which is not safe for atomic context. The patchset solves this in patch 3/4 by handling clocks in different way if device driver set interrupt safe runtime PM. Any comments are welcome. Tested on boards with pl330 DMA driver: - Trats2 (Exynos4212) - Samsung Gear2-like development board (Exynos3250) TODO/ideas: =========== Consider renaming existing pm_runtime_irq_safe() function to keep up with naming convention after adding pm_runtime_is_irq_safe() in patch 1/4. This naming: - pm_runtime_irq_safe() as setter, - pm_runtime_is_irq_safe() as getter, is contradictory to naming of other PM runtime functions, e.g.: - pm_runtime_set_active() as setter, - pm_runtime_active() as getter. I didn't change the naming of pm_runtime_irq_safe() because I wanted to minimize the impact of the patches. Changes since v4: ================= 1. Patch 3/4: Explicitly initialize amba_device.irq_safe field after probing driver (suggested by Russell King). Changes since v3: ================= 1. Patch 1/4: Document new API in Documentation/power/runtime_pm.txt (pointed by Alan Stern). Changes since v2: ================= 1. Add patch 1 (PM / Runtime: Add getter for quering the IRQ safe option) 2. Add patch 2 (amba: Add helper macros for (un)preparing AMBA clock) 3. Patch 3/4: Rewrite the idea. If IRQ safe runtime PM is set then do not unprepare/prepare the clocks. Suggested by Russell King. 4. Patch 4/4: During system sleep unprepare the clock. Changes since v1: ================= 1. Add patch 1 (amba: Allow AMBA drivers to use their own runtime PM). 2. Patch 2/2: Apply Michal Simek's suggestions. 3. Patch 2/2: Fix atomic context safeness in pl330_issue_pending(). Best regards, Krzysztof Kozlowski Krzysztof Kozlowski (4): PM / Runtime: Add getter for quering the IRQ safe option amba: Add helper macros for (un)preparing AMBA clock amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM dma: pl330: add Power Management support Documentation/power/runtime_pm.txt | 4 ++ drivers/amba/bus.c | 29 ++++++++++++-- drivers/dma/pl330.c | 77 ++++++++++++++++++++++++++++++++++++-- include/linux/amba/bus.h | 7 ++++ include/linux/pm_runtime.h | 6 +++ 5 files changed, 115 insertions(+), 8 deletions(-) -- 1.9.1