From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] checkpatch: check for subject uniqueness in git repository.
Date: Tue, 16 Sep 2014 09:31:34 -0700 [thread overview]
Message-ID: <1410885094.16519.6.camel@joe-AO725> (raw)
In-Reply-To: <1685749151.185639.1410884118738.open-xchange@webmail.nmp.skynet.be>
On Tue, 2014-09-16 at 18:15 +0200, Fabian Frederick wrote:
> > On 16 September 2014 at 05:22 Joe Perches <joe@perches.com> wrote:
> > On Mon, 2014-09-15 at 20:43 +0200, Fabian Frederick wrote:
> > > Adding patch subject uniqueness check in checkpatch --strict mode.
> > > See Documentation/SubmittingPatches/globally-unique identifier.
> >
> > Perhaps something like this?
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > + if ($check && $#git_commits < 1 && which("git") && -e ".git") {
> > + my $output = `git log --no-color --format='%H %s' 2>&1`;
> > + $output =~ s/^\s*//gm;
> > + @git_commits = split("\n", $output);
> > + }
> Perfect ! :)
Except for that _really, really_ long time to do the
git log of all commits...
Maybe the git log should be enabled only with another
command-line option.
next prev parent reply other threads:[~2014-09-16 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 18:43 Fabian Frederick
2014-09-15 21:02 ` Joe Perches
2014-09-16 3:22 ` Joe Perches
2014-09-16 16:15 ` Fabian Frederick
2014-09-16 16:31 ` Joe Perches [this message]
2014-09-20 10:31 ` Fabian Frederick
2014-09-20 16:07 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410885094.16519.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®