From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <dan.j.williams@intel.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: [PATCH v3 1/2] dmaengine: omap-dma: Add memory barrier to dma_resume path
Date: Tue, 16 Sep 2014 22:45:56 +0300 [thread overview]
Message-ID: <1410896757-3848-2-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1410896757-3848-1-git-send-email-peter.ujfalusi@ti.com>
Add mb() call to resume path to ensure the necessary barrier.
Resume can happen after waking up from suspend for example.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/dma/omap-dma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 4cf7d9a950d7..c01ea505ee7c 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -1017,6 +1017,8 @@ static int omap_dma_resume(struct omap_chan *c)
return -EINVAL;
if (c->paused) {
+ mb();
+
omap_dma_start(c, c->desc);
c->paused = false;
}
--
2.1.0
next prev parent reply other threads:[~2014-09-16 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 19:45 [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume Peter Ujfalusi
2014-09-16 19:45 ` Peter Ujfalusi [this message]
2014-09-16 19:45 ` [PATCH v3 2/2] dmaengine: omap-dma: Restore the CLINK_CTRL in resume path Peter Ujfalusi
2014-09-17 18:38 ` [PATCH v3 0/2] dmaengine: omap-dma: Fix cyclic suspend/resume Peter Ujfalusi
2014-09-23 12:53 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410896757-3848-2-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®