From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757187AbaIQVsg (ORCPT ); Wed, 17 Sep 2014 17:48:36 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:39490 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757117AbaIQVsb (ORCPT ); Wed, 17 Sep 2014 17:48:31 -0400 From: Frans Klaver To: Darren Hart Cc: Frans Klaver , Corentin Chary , Rafael Wysocki , Greg Kroah-Hartman , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 9/9] eeepc-laptop: store_cpufv: return error if set_acpi fails Date: Wed, 17 Sep 2014 23:47:27 +0200 Message-Id: <1410990447-3210-10-git-send-email-fransklaver@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1410990447-3210-1-git-send-email-fransklaver@gmail.com> References: <1410990447-3210-1-git-send-email-fransklaver@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The result of set_acpi is left unchecked, but it may return errors. If one occurs, send the error to the caller. There's no reason to lie about it, if set_acpi fails. Signed-off-by: Frans Klaver --- drivers/platform/x86/eeepc-laptop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index 875a43f..3f6c762 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -388,7 +388,9 @@ static ssize_t cpufv_store(struct device *dev, return rv; if (value < 0 || value >= c.num) return -EINVAL; - set_acpi(eeepc, CM_ASL_CPUFV, value); + rv = set_acpi(eeepc, CM_ASL_CPUFV, value); + if (rv) + return rv; return count; } -- 2.1.0