From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756776AbaISMqw (ORCPT ); Fri, 19 Sep 2014 08:46:52 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:57900 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756232AbaISMqv (ORCPT ); Fri, 19 Sep 2014 08:46:51 -0400 Message-ID: <1411130808.7106.302.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH net-next V2] net: keep original skb which only needs header checking during software GSO From: Eric Dumazet To: Jason Wang Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 19 Sep 2014 05:46:48 -0700 In-Reply-To: <1411113878-11910-1-git-send-email-jasowang@redhat.com> References: <1411113878-11910-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-09-19 at 16:04 +0800, Jason Wang wrote: > Commit ce93718fb7cdbc064c3000ff59e4d3200bdfa744 ("net: Don't keep > around original SKB when we software segment GSO frames") frees the > original skb after software GSO even for dodgy gso skbs. This breaks > the stream throughput from untrusted sources, since only header > checking was done during software GSO instead of a true > segmentation. This patch fixes this by freeing the original gso skb > only when it was really segmented by software. > > Fixes ce93718fb7cdbc064c3000ff59e4d3200bdfa744 ("net: Don't keep > around original SKB when we software segment GSO frames.") > > Cc: David S. Miller > Cc: Eric Dumazet > Signed-off-by: Jason Wang > --- Acked-by: Eric Dumazet