From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbaIVTiB (ORCPT ); Mon, 22 Sep 2014 15:38:01 -0400 Received: from top.free-electrons.com ([176.31.233.9]:51403 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753576AbaIVTiA (ORCPT ); Mon, 22 Sep 2014 15:38:00 -0400 From: Boris BREZILLON To: Samuel Ortiz , Lee Jones Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Boris BREZILLON Subject: [PATCH] mfd: inherit coherent_dma_mask from parent device Date: Mon, 22 Sep 2014 21:37:55 +0200 Message-Id: <1411414675-19010-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma_mask and dma_parms are already inherited from the parent device but dma_coherent_mask was left uninitialized (set to zero thanks to kzalloc). Set sub-device coherent_dma_mask to its parent value to simplify sub-drivers making use of dma coherent helper functions (those drivers currently have to explicitly set the dma coherent mask using dma_set_coherent_mask function). Signed-off-by: Boris BREZILLON --- Hi, This patch is follow-up of a discussion we had on a KMS driver thread [1]. This patch is only copying the parent device coherent_dma_mask to avoid calling specific dma_set_coherent_mask in case the coherent mask is the default one. I'm a bit surprised this hasn't been done earlier while other dma fields (mask and parms) are already inherited from the parent device, so please tell me if there already was an attempt to do the same, and if so, what was the reson for rejecting it :-). Best Regards, Boris [1]https://lkml.org/lkml/2014/9/22/392 drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index 892d343..5d0fbe1 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -101,6 +101,7 @@ static int mfd_add_device(struct device *parent, int id, pdev->dev.type = &mfd_dev_type; pdev->dev.dma_mask = parent->dma_mask; pdev->dev.dma_parms = parent->dma_parms; + pdev->dev.coherent_dma_mask = parent->coherent_dma_mask; ret = regulator_bulk_register_supply_alias( &pdev->dev, cell->parent_supplies, -- 1.9.1