From: Chuansheng Liu <chuansheng.liu@intel.com>
To: tj@kernel.org, rjw@rjwysocki.net
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
mister.freeman@laposte.net, rui.zhang@intel.com,
chuansheng.liu@intel.com
Subject: [PATCH] ata: Disabling the async PM for JMicron chips
Date: Tue, 23 Sep 2014 13:37:51 +0800 [thread overview]
Message-ID: <1411450671-2367-1-git-send-email-chuansheng.liu@intel.com> (raw)
Be similar with commit (ata: Disabling the async PM for JMicron chip 363/361),
Barto found the similar issue for JMicron chip 368, that 363/368 has no
parent-children relationship, but they have the power dependency.
So here we can exclude the JMicron chips out of pm_async method directly,
to avoid further similar issues.
Details in:
https://bugzilla.kernel.org/show_bug.cgi?id=84861
Reported-and-tested-by: Barto <mister.freeman@laposte.net>
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
---
drivers/ata/ahci.c | 6 +++---
drivers/ata/pata_jmicron.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index a0cc0ed..c096d49 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
* follow the sequence one by one, otherwise one of them can not be
* powered on successfully, so here we disable the async suspend
* method for these chips.
+ * Jmicron chip 368 has been found has the similar issue, here we can
+ * exclude the Jmicron family directly to avoid other similar issues.
*/
- if (pdev->vendor == PCI_VENDOR_ID_JMICRON &&
- (pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 ||
- pdev->device == PCI_DEVICE_ID_JMICRON_JMB361))
+ if (pdev->vendor == PCI_VENDOR_ID_JMICRON)
device_disable_async_suspend(&pdev->dev);
/* acquire resources */
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
index 47e418b..48c993b 100644
--- a/drivers/ata/pata_jmicron.c
+++ b/drivers/ata/pata_jmicron.c
@@ -149,10 +149,10 @@ static int jmicron_init_one (struct pci_dev *pdev, const struct pci_device_id *i
* follow the sequence one by one, otherwise one of them can not be
* powered on successfully, so here we disable the async suspend
* method for these chips.
+ * Jmicron chip 368 has been found has the similar issue, here we can
+ * exclude the Jmicron family directly to avoid other similar issues.
*/
- if (pdev->vendor == PCI_VENDOR_ID_JMICRON &&
- (pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 ||
- pdev->device == PCI_DEVICE_ID_JMICRON_JMB361))
+ if (pdev->vendor == PCI_VENDOR_ID_JMICRON)
device_disable_async_suspend(&pdev->dev);
return ata_pci_bmdma_init_one(pdev, ppi, &jmicron_sht, NULL, 0);
--
1.7.9.5
next reply other threads:[~2014-09-23 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 5:37 Chuansheng Liu [this message]
2014-09-23 14:00 ` Tejun Heo
2014-09-24 6:20 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411450671-2367-1-git-send-email-chuansheng.liu@intel.com \
--to=chuansheng.liu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mister.freeman@laposte.net \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®