From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757305AbaIXB1y (ORCPT ); Tue, 23 Sep 2014 21:27:54 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:40128 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbaIXB1w (ORCPT ); Tue, 23 Sep 2014 21:27:52 -0400 Message-ID: <1411522047.3659.10.camel@decadent.org.uk> Subject: Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore From: Ben Hutchings To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Amit Shah , Rusty Russell , virtualization@lists.linux-foundation.org Date: Wed, 24 Sep 2014 02:27:27 +0100 In-Reply-To: <1411468217-18130-1-git-send-email-mst@redhat.com> References: <1411468217-18130-1-git-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-mq3v38JDLSng1LxLnV2N" X-Mailer: Evolution 3.12.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.249 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-mq3v38JDLSng1LxLnV2N Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-09-23 at 13:32 +0300, Michael S. Tsirkin wrote: > On restore, virtio pci does the following: > + set features > + init vqs etc - device can be used at this point! > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits >=20 > This is in violation of the virtio spec, which > requires the following order: > - ACKNOWLEDGE > - DRIVER > - init vqs > - DRIVER_OK > > Cc: stable@vger.kernel.org > Cc: Amit Shah > Signed-off-by: Michael S. Tsirkin [...] What concrete problem does this fix, such that it should be applied to stable branches? Ben. --=20 Ben Hutchings Everything should be made as simple as possible, but not simpler. - Albert Einstei= n --=-mq3v38JDLSng1LxLnV2N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIVAwUAVCIeD+e/yOyVhhEJAQrGfg/9G+X39+ucRMByTRkTaDvgAVIVGbBn2dOt qPHPZBSlEKC3syUF9i9CiYoeKAprCjeIeAXebSArUa/xzk9PRDOPucuBrod4Fqa7 cIzfu9Z8DBs2ArqNjmb4H/8E8v4a0zFhf4oHswT39IhrjJyJBMjr10FfYfikQLWU 8EE/epJGqmFwNgG56DwlSoqD80sGoLO18Z/YzSUQNeLnpH6w5jgdRim39AMejG5s eRgSmFZLWhI/kobrr1u/9kx+FoAg5KY98OfNOPz4tRevttB2wPRtuO6KAkjd4ViE ZABAWckDJ3H0IADAquchMTwnbcss1enflJu9/sW9aJ5tq8ptU8rT4+GiPFuU+1na peZMDmidhLH2HBhJg8c+osHGpsGPSdZ1c/Hv7M/6/3hS/J0HoDQsBItiv2DElaUX AWYfp7ipTtl9mqU3EqHFOVx3femG81Nya55irwkcIZGyBq4Iei0GxQc7n1TNvFc9 2POqqhfVeHBEAI+yoUisIlVXUtraKuSACjK6XyRo8kZEH2iQ2/NCUFOOfdABTHyZ 54cPxOuMHY9jvCoj1hOSXrX6AHNGUq0MePRyrNrd3MuLsve8fdG0mU3IAUjRRmAJ eWUp9Z9dz0kA9kwwTg3pvL300BZ0h8eMC8b5SkbgEj418qmsZrwXFfPGuXO1pATx wegeHNn+jF4= =id0T -----END PGP SIGNATURE----- --=-mq3v38JDLSng1LxLnV2N--