From: Joe Perches <joe@perches.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
tapaswenipathak@gmail.com, opw-kernel@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
Dan Carpenter <error27@gmail.com>,
Andy Whitcroft <apw@canonical.com>
Subject: checkpatch: Does anyone care that comments are freeform aligned?
Date: Wed, 24 Sep 2014 11:41:14 -0700 [thread overview]
Message-ID: <1411584074.3594.17.camel@joe-AO725> (raw)
In-Reply-To: <alpine.DEB.2.02.1409240745160.2051@localhost6.localdomain6>
On Wed, 2014-09-24 at 07:47 +0200, Julia Lawall wrote:
> In the following patch extract, one line is indented with spaces rather
> than tabs. Is it intentional that checkpatch doesn't complain about this,
> I guess due to the line being a comment?
[]
> struct bcm_hdr_suppression_contextinfo {
> - UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS]; /* Intermediate buffer to accumulate pkt Header for PHS */
> - UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN]; /* Intermediate buffer containing pkt Header after PHS */
> + /* Intermediate buffer to accumulate pkt Header for PHS */
> + UCHAR ucaHdrSuppressionInBuf[MAX_PHS_LENGTHS];
> + /* Intermediate buffer containing pkt Header after PHS */
> + UCHAR ucaHdrSuppressionOutBuf[MAX_PHS_LENGTHS + PHSI_LEN];
> };
checkpatch does not care when comments start in any
particular position or ensure comments have tabs
preceding them.
Does anyone care?
next parent reply other threads:[~2014-09-24 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.02.1409240745160.2051@localhost6.localdomain6>
2014-09-24 18:41 ` Joe Perches [this message]
2014-09-26 23:03 ` [OPW kernel] " josh
2014-09-27 4:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411584074.3594.17.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=error27@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=opw-kernel@googlegroups.com \
--cc=tapaswenipathak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®