mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Elshad Mustafayev <elshadimo@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning
Date: Wed, 24 Sep 2014 22:05:46 -0700	[thread overview]
Message-ID: <1411621546.4026.10.camel@joe-AO725> (raw)
In-Reply-To: <20140925050004.GM7996@ZenIV.linux.org.uk>

On Thu, 2014-09-25 at 06:00 +0100, Al Viro wrote:
> It's not you, it's checkpatch.pl plus the fairly common tendency to give
> that thing a lot more respect than it deserves...
> 
> Basically, it's OK as a tool that draws ones attention to a subset of
> code that might or might not be worth looking at; it gives both false
> positives and false negatives and as long as there's not too much of those,
> it's useful.  Provided that it does *not* replace one's taste.  I.e. "hey,
> it points to these lines; let's take a look, some of those might be
> worth some attention", rather than "The Most Holy Oracle Has Spoken;
> Do What It Says".

Just so.


  reply	other threads:[~2014-09-25  5:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1XX0bN-00032o-0x@feisty.vs19.net>
2014-09-25  4:31 ` Joe Perches
     [not found]   ` <CAAm9=9QeO_VtdY+fJ5JbrBhN52z=JUeU09Nh3Mp04QWf+Qyygw@mail.gmail.com>
2014-09-25  5:00     ` Al Viro
2014-09-25  5:05       ` Joe Perches [this message]
2014-09-25  5:03   ` [PATCH] checkpatch: Add exception to return then else test Joe Perches
2014-09-25  3:13 [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning Elshad Mustafayev
2014-09-25  3:22 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411621546.4026.10.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=elshadimo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®