From: Lan Tianyu <tianyu.lan@intel.com>
To: peterz@infradead.org, mingo@kernel.org,
rafael.j.wysocki@intel.com, toshi.kani@hp.com,
akpm@linux-foundation.org, tianyu.lan@intel.com,
ktkhai@parallels.com, fabf@skynet.be, laijs@cn.fujitsu.com,
srivatsa.bhat@linux.vnet.ibm.com, ego@linux.vnet.ibm.com,
srivatsa@mit.edu, viresh.kumar@linaro.org
Cc: todd.e.brandt@linux.intel.com, tipbot@zytor.com,
wangyun@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: [RFC PATCH V3 3/3] Cpufreq: Hold cpu_add_remove_lock before change cpufreq_suspended flag
Date: Thu, 25 Sep 2014 16:32:05 +0800 [thread overview]
Message-ID: <1411633925-9018-4-git-send-email-tianyu.lan@intel.com> (raw)
In-Reply-To: <1411633925-9018-1-git-send-email-tianyu.lan@intel.com>
Now, enabling non-boot cpus will parallel with resuming devices.
Cpu online may take place after cpufreq resume. But all cpu should be up
before clearing cpufreq_suspended flag in the cpufreq_resume(). Cpufreq
core uses this flag to decide to do light-weight init or full init. Light
-weight init/tear down is dedicated for cpu hotplug during system pm. To
keep this rule, hold cpu_add_remove_lock during changing cpufreq_suspended
flag.
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
---
drivers/cpufreq/cpufreq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 37951ec..b03f7dd 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1689,7 +1689,9 @@ void cpufreq_resume(void)
if (!cpufreq_driver)
return;
+ cpu_maps_update_begin();
cpufreq_suspended = false;
+ cpu_maps_update_done();
if (!has_target())
return;
--
1.8.4.rc0.1.g8f6a3e5.dirty
next prev parent reply other threads:[~2014-09-25 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:32 [RFC PATCH V3 0/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices Lan Tianyu
2014-09-25 8:32 ` [RFC PATCH V3 1/3] " Lan Tianyu
2014-09-25 8:32 ` [RFC PATCH V2 2/3] X86/CPU: Initialize MTRR/PAT when each cpu is online during system resume Lan Tianyu
2014-09-25 8:32 ` Lan Tianyu [this message]
2014-10-08 20:54 ` [RFC PATCH V3 0/3] PM/CPU: Parallel enalbing nonboot cpus with resume devices Peter Zijlstra
2014-10-08 22:01 ` Rafael J. Wysocki
2014-10-09 1:18 ` Lan Tianyu
2014-10-22 6:06 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411633925-9018-4-git-send-email-tianyu.lan@intel.com \
--to=tianyu.lan@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ego@linux.vnet.ibm.com \
--cc=fabf@skynet.be \
--cc=ktkhai@parallels.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=srivatsa@mit.edu \
--cc=tipbot@zytor.com \
--cc=todd.e.brandt@linux.intel.com \
--cc=toshi.kani@hp.com \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®