From: Grzegorz Jaszczyk <jaz@semihalf.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: tglx@linutronix.de, jason@lakedaemon.net,
ezequiel.garcia@free-electrons.com,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, alior@marvell.com,
tawfik@marvell.com, mw@semihalf.com, jaz@semihalf.com
Subject: [PATCH 1/2] irqchip: armada-370-xp: fix MSI interrupt handling
Date: Thu, 25 Sep 2014 13:17:18 +0200 [thread overview]
Message-ID: <1411643839-64925-2-git-send-email-jaz@semihalf.com> (raw)
In-Reply-To: <1411643839-64925-1-git-send-email-jaz@semihalf.com>
The MSI interrupts use the 16 high doorbells, which are notified by using IRQ1
of the main interrupt controller.
The MSI interrupts were handled correctly for Armada-XP and Armada-370 but not
for Armada-375 and Armada-38x, which use chained handler for the MPIC.
This commit fixes that by checking proper interrupt number in chained handler
for the MPIC.
Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/irqchip/irq-armada-370-xp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index 574aba0..91424c4 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -417,9 +417,9 @@ static void armada_370_xp_mpic_handle_cascade_irq(unsigned int irq,
irqmap = readl_relaxed(per_cpu_int_base + ARMADA_375_PPI_CAUSE);
- if (irqmap & BIT(0)) {
+ if (irqmap & BIT(1)) {
armada_370_xp_handle_msi_irq(NULL, true);
- irqmap &= ~BIT(0);
+ irqmap &= ~BIT(1);
}
for_each_set_bit(irqn, &irqmap, BITS_PER_LONG) {
--
1.8.3.1
next prev parent reply other threads:[~2014-09-25 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 11:17 [PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes Grzegorz Jaszczyk
2014-09-25 11:17 ` Grzegorz Jaszczyk [this message]
2014-09-25 11:17 ` [PATCH 2/2] irqchip: armada-370-xp: fix MPIC interrupt handling Grzegorz Jaszczyk
2014-09-25 21:56 ` [PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes Ezequiel Garcia
2014-10-03 13:50 ` Jason Cooper
2014-10-21 14:19 ` Ezequiel Garcia
2014-10-21 15:14 ` Jason Cooper
2014-10-21 21:22 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411643839-64925-2-git-send-email-jaz@semihalf.com \
--to=jaz@semihalf.com \
--cc=alior@marvell.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=tawfik@marvell.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®