mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sjoerd Simons <sjoerd@luon.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnurou@gmail.com
Subject: Re: [5/5] ARM: tegra: jetson-tk1: enable GK20A GPU
Date: Thu, 25 Sep 2014 20:10:31 +0200	[thread overview]
Message-ID: <1411668631.24948.9.camel@luon.net> (raw)
In-Reply-To: <20140925164109.GA30382@ulmo>

On Thu, 2014-09-25 at 18:41 +0200, Thierry Reding wrote:
> On Thu, Sep 25, 2014 at 09:48:01AM -0600, Stephen Warren wrote:
> > On 09/25/2014 07:27 AM, Sjoerd Simons wrote:
> > >Playing a bit with todays linux-next on my jetson, it seems this patch is
> > >still required for enabling the GPU. Is there anything blocking it (firmware
> > >not available yet in liux-firmware?)
> > 
> > I think initially I was waiting for the DRM patch "drm/nouvea: support for
> > probing platform devices" to be applied, but it looks like that's been
> > applied already, so only patches 4 and 5 in this series are still
> > outstanding.
> > 
> > Alex, wasn't there also some issue where the VPR register had to be
> > programmed, and if it wasn't there'd be a hang when the GPU registers were
> > touched? If we've added code to Nouveau/tegradrm to detect that and avoid
> > the problem, then I guess we can commit these last two patches for 3.19. A
> > resend after the 3.18 merge window might help.
> 
> A patch that programs VPR was merged into U-Boot (though I don't think
> it's made it into master yet).

Assuming you're talking about "ARM: tegra: Disable VPR",that has landed
in u-boot master and released as part of v2014.10-rc2 [0]

>  I'm not sure we can reasonably check for
> that in Nouveau, given that the register is somewhere completely
> unrelated. In fact I think the U-Boot patch was triggered by some
> discussion about how to solve this and it was decided that it shouldn't
> be done in the kernel, but U-Boot should set it up.
> 
> That said, perhaps one solution would be to make U-Boot enable the gk20a
> device if it's set up the VPR and disable it otherwise?

I guess in that case the vdd-supply should still be added to the dts
with u-boot toggling the status field of the node?


0: http://git.denx.de/?p=u-boot.git;a=commit;h=df3443dfa449ad02bef8ddf6e2c90a6fd9394fc9
-- 
Sjoerd Simons <sjoerd@luon.net>

  parent reply	other threads:[~2014-09-25 18:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19  9:24 [PATCH 0/5] drm/nouveau: platform devices and GK20A probing Alexandre Courbot
2014-05-19  9:24 ` [PATCH 1/5] drm/nouveau: support for probing platform devices Alexandre Courbot
2014-05-19  9:24 ` [PATCH 2/5] ARM: tegra: of: add GK20A device tree binding Alexandre Courbot
2014-05-19 21:14   ` Stephen Warren
2014-05-23  7:13     ` Alexandre Courbot
2014-05-19  9:24 ` [PATCH 3/5] ARM: tegra: add GK20A GPU to Tegra124 DT Alexandre Courbot
2014-05-19 21:16   ` Stephen Warren
2014-05-19  9:24 ` [PATCH 4/5] ARM: tegra: venice2: enable GK20A GPU Alexandre Courbot
2014-05-19  9:24 ` [PATCH 5/5] ARM: tegra: jetson-tk1: " Alexandre Courbot
2014-09-25 13:27   ` [5/5] " Sjoerd Simons
2014-09-25 15:48     ` Stephen Warren
2014-09-25 16:41       ` Thierry Reding
2014-09-25 18:07         ` Stephen Warren
2014-09-26  9:59           ` Thierry Reding
2014-09-25 18:10         ` Sjoerd Simons [this message]
2014-09-26 10:01           ` Thierry Reding
2014-09-26  4:44       ` Alexandre Courbot
2014-05-19 10:04 ` [PATCH 0/5] drm/nouveau: platform devices and GK20A probing Lucas Stach
2014-05-19 10:06   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411668631.24948.9.camel@luon.net \
    --to=sjoerd@luon.net \
    --cc=acourbot@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome