From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: hpa@zytor.org, mingo@redhat.com, tglx@linutronix.de,
hmh@hmh.eng.br, boon.leong.ong@intel.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
"Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Subject: [PATCH] x86: Quark: Add if/else to setup_arch for Quark TLB bug
Date: Fri, 26 Sep 2014 18:19:45 +0100 [thread overview]
Message-ID: <1411751985-4351-1-git-send-email-pure.logic@nexus-software.ie> (raw)
Quark X1000 incorrectly advertises PGE. In later the stages of boot
specifically in early_init_intel we setup_clear_cpu_cap for PGE.
At this point in time cpu_has_pge() will still be true.
Use the boot_cpu_data to decide if __flush_tlb_all() or __flush_tlb()
should be called subsequent to loading CR3
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
---
arch/x86/kernel/setup.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 41ead8d..8e61d5e 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -879,7 +879,20 @@ void __init setup_arch(char **cmdline_p)
KERNEL_PGD_PTRS);
load_cr3(swapper_pg_dir);
- __flush_tlb_all();
+
+ /*
+ * Flush the TLB after loading CR3
+ *
+ * Quark X1000 wrongly advertises PGE. Use boot_cpu_data to
+ * to make sure the TLB is flushed correctly in the early
+ * stage of setup_arch() for Quark X1000.
+ * X86_FEATURE_PGE flag is only setup later stage at
+ * early_cpu_init();
+ */
+ if (boot_cpu_data.x86 == 5 && boot_cpu_data.x86_model == 9)
+ __flush_tlb();
+ else
+ __flush_tlb_all();
#else
printk(KERN_INFO "Command line: %s\n", boot_command_line);
#endif
--
1.9.1
next reply other threads:[~2014-09-26 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 17:19 Bryan O'Donoghue [this message]
2014-09-26 17:35 ` Dave Jones
2014-09-26 17:40 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411751985-4351-1-git-send-email-pure.logic@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=boon.leong.ong@intel.com \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®