mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: [RESEND char-misc-next 01/18] mei: add hbm and pg state in devstate debugfs print
Date: Mon, 29 Sep 2014 16:31:33 +0300	[thread overview]
Message-ID: <1411997510-29094-2-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1411997510-29094-1-git-send-email-tomas.winkler@intel.com>

From: Alexander Usyskin <alexander.usyskin@intel.com>

Add hbm state, pg enablement and state to devstate file in debugfs
(<debugfs>/mei/devstate)

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/misc/mei/debugfs.c |  7 ++++++-
 drivers/misc/mei/hbm.c     | 16 ++++++++++++++++
 drivers/misc/mei/hbm.h     |  2 ++
 drivers/misc/mei/init.c    | 12 ++++++++++++
 drivers/misc/mei/mei_dev.h |  2 ++
 5 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
index 3b03288..2399b31 100644
--- a/drivers/misc/mei/debugfs.c
+++ b/drivers/misc/mei/debugfs.c
@@ -134,8 +134,13 @@ static ssize_t mei_dbgfs_read_devstate(struct file *fp, char __user *ubuf,
 	if  (!buf)
 		return -ENOMEM;
 
-	pos += scnprintf(buf + pos, bufsz - pos, "%s\n",
+	pos += scnprintf(buf + pos, bufsz - pos, "dev: %s\n",
 			mei_dev_state_str(dev->dev_state));
+	pos += scnprintf(buf + pos, bufsz - pos, "hbm: %s\n",
+			mei_hbm_state_str(dev->hbm_state));
+	pos += scnprintf(buf + pos, bufsz - pos, "pg:  %s, %s\n",
+			mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED",
+			mei_pg_state_str(mei_pg_state(dev)));
 	ret = simple_read_from_buffer(ubuf, cnt, ppos, buf, pos);
 	kfree(buf);
 	return ret;
diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
index 9fc051b..3311b5c 100644
--- a/drivers/misc/mei/hbm.c
+++ b/drivers/misc/mei/hbm.c
@@ -56,6 +56,22 @@ static const char *mei_cl_conn_status_str(enum mei_cl_connect_status status)
 #undef MEI_CL_CCS
 }
 
+const char *mei_hbm_state_str(enum mei_hbm_state state)
+{
+#define MEI_HBM_STATE(state) case MEI_HBM_##state: return #state
+	switch (state) {
+	MEI_HBM_STATE(IDLE);
+	MEI_HBM_STATE(STARTING);
+	MEI_HBM_STATE(STARTED);
+	MEI_HBM_STATE(ENUM_CLIENTS);
+	MEI_HBM_STATE(CLIENT_PROPERTIES);
+	MEI_HBM_STATE(STOPPED);
+	default:
+		return "unknown";
+	}
+#undef MEI_HBM_STATE
+}
+
 /**
  * mei_cl_conn_status_to_errno - convert client connect response
  * status to error code
diff --git a/drivers/misc/mei/hbm.h b/drivers/misc/mei/hbm.h
index 80920f0..efcb0d4 100644
--- a/drivers/misc/mei/hbm.h
+++ b/drivers/misc/mei/hbm.h
@@ -40,6 +40,8 @@ enum mei_hbm_state {
 	MEI_HBM_STOPPED,
 };
 
+const char *mei_hbm_state_str(enum mei_hbm_state state);
+
 int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr);
 
 static inline void mei_hbm_hdr(struct mei_msg_hdr *hdr, size_t length)
diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
index 9f635be..81695e4 100644
--- a/drivers/misc/mei/init.c
+++ b/drivers/misc/mei/init.c
@@ -43,6 +43,18 @@ const char *mei_dev_state_str(int state)
 #undef MEI_DEV_STATE
 }
 
+const char *mei_pg_state_str(enum mei_pg_state state)
+{
+#define MEI_PG_STATE(state) case MEI_PG_##state: return #state
+	switch (state) {
+	MEI_PG_STATE(OFF);
+	MEI_PG_STATE(ON);
+	default:
+		return "unknown";
+	}
+#undef MEI_PG_STATE
+}
+
 
 /**
  * mei_cancel_work. Cancel mei background jobs
diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
index 719edee..be7b147 100644
--- a/drivers/misc/mei/mei_dev.h
+++ b/drivers/misc/mei/mei_dev.h
@@ -375,6 +375,8 @@ enum mei_pg_state {
 	MEI_PG_ON =  1,
 };
 
+const char *mei_pg_state_str(enum mei_pg_state state);
+
 /*
  * mei_cfg
  *
-- 
1.9.3


  reply	other threads:[~2014-09-29 13:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 13:31 [RESEND char-misc-next 00/18] mei: resend of rebased patches Tomas Winkler
2014-09-29 13:31 ` Tomas Winkler [this message]
2014-09-29 13:31 ` [RESEND char-misc-next 02/18] mei: debugfs: adjust print buffer Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 03/18] mei: debugfs: add single buffer indicator Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 04/18] mei: pg: fix cat and paste error in comments Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 05/18] mei: fix style warning: Missing a blank line after declarations Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 06/18] mei: nfc: fix style warning Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 07/18] mei: kill error message for allocation failure Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 08/18] mei: move mei_hbm_hdr function from hbm.h the hbm.c Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 09/18] mei: push all standard settings into mei_device_init Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 10/18] mei: get rid of most of the pci dependencies in mei Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 11/18] mei: move fw_status back to hw ops handlers Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 12/18] mei: remove the reference to pdev from mei_device Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 13/18] mei: push pci cfg structure me hw Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 14/18] mei: remove include to pci header from mei module files Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 15/18] mei: trivial: fix errors in prints in comments Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 16/18] mei: drop me_client_presentation_num Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 17/18] mei: fix KDoc documentation formatting Tomas Winkler
2014-09-29 13:31 ` [RESEND char-misc-next 18/18] mei: fix kernel-doc warnings Tomas Winkler
2014-09-29 15:56 ` [RESEND char-misc-next 00/18] mei: resend of rebased patches Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411997510-29094-2-git-send-email-tomas.winkler@intel.com \
    --to=tomas.winkler@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®