mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thibaut Robert <thibaut.robert@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michalis Pappas <mpappas@fastmail.fm>,
	Davide Gianforte <davide@gengisdave.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Thibaut Robert <thibaut.robert@gmail.com>
Subject: [PATCH] Staging: gdm72xx: fix coding style
Date: Mon, 29 Sep 2014 20:15:35 +0200	[thread overview]
Message-ID: <1412014535-24239-1-git-send-email-thibaut.robert@gmail.com> (raw)

This patch remove a checkstyle warning in netlink_k.c.
Note: This is my homework of the day.

Signed-off-by: Thibaut Robert <thibaut.robert@gmail.com>
---
 drivers/staging/gdm72xx/netlink_k.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/gdm72xx/netlink_k.c b/drivers/staging/gdm72xx/netlink_k.c
index 9bf00e6..0a5831a 100644
--- a/drivers/staging/gdm72xx/netlink_k.c
+++ b/drivers/staging/gdm72xx/netlink_k.c
@@ -147,12 +147,11 @@ int netlink_send(struct sock *sock, int group, u16 type, void *msg, int len)
 
 	if (!ret) {
 		return len;
-	} else {
-		if (ret != -ESRCH) {
-			pr_err("netlink_broadcast g=%d, t=%d, l=%d, r=%d\n",
-			       group, type, len, ret);
-		}
-		ret = 0;
 	}
-	return ret;
+
+	if (ret != -ESRCH) {
+		pr_err("netlink_broadcast g=%d, t=%d, l=%d, r=%d\n",
+		       group, type, len, ret);
+	}
+	return 0;
 }
-- 
1.9.1


             reply	other threads:[~2014-09-29 18:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 18:15 Thibaut Robert [this message]
2014-09-29 18:31 ` Joe Perches
2014-09-30 10:20   ` Thibaut Robert
2014-09-30 10:23   ` Thibaut Robert
2014-09-30 11:02     ` Thibaut Robert
2014-09-30 11:03   ` [PATCH] staging: gdm72xx: fix typo and " Thibaut Robert
2014-10-05  1:18     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412014535-24239-1-git-send-email-thibaut.robert@gmail.com \
    --to=thibaut.robert@gmail.com \
    --cc=davide@gengisdave.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpappas@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome