From: Joe Perches <joe@perches.com>
To: Eric Rost <eric.rost@mybabylon.net>
Cc: gregkh@linuxfoundation.org, jason@lakedaemon.net, jake@lwn.net,
antonysaraev@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] staging: skein: Additional Whitespace Issues
Date: Mon, 29 Sep 2014 23:35:47 -0700 [thread overview]
Message-ID: <1412058947.4302.88.camel@joe-AO725> (raw)
In-Reply-To: <86fca4750dfba1c25d7d8b3b5cb5f019e756fed7.1412056800.git.eric.rost@mybabylon.net>
On Tue, 2014-09-30 at 01:10 -0500, Eric Rost wrote:
> Fixes leading and trailing whitespace issues.
[]
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
[]
> @@ -36,7 +36,7 @@
> #define debug_save_tweak(ctx) \
> { \
> ctx->h.tweak[0] = ts[0]; \
> - ctx->h.tweak[1] = ts[1]; \
> + ctx->h.tweak[1] = ts[1]; \
I know it's an extra step to reintegrate these, but
please don't introduce whitespace problems in patch 1
that you fix in patch 2.
Do it correctly in patch 1.
next prev parent reply other threads:[~2014-09-30 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 6:07 [PATCH v2 0/4] staging: skein: Fixes whitespace warnings Eric Rost
2014-09-30 6:09 ` [PATCH v2 1/4] staging: skein: Whitespace cleanup Eric Rost
2014-09-30 6:10 ` [PATCH v2 2/4] staging: skein: Additional Whitespace Issues Eric Rost
2014-09-30 6:35 ` Joe Perches [this message]
2014-09-30 6:12 ` [PATCH v2 3/4] staging: skein: In progress changes Eric Rost
2014-09-30 6:13 ` [PATCH v2 4/4] staging: skein: File Reorg Eric Rost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412058947.4302.88.camel@joe-AO725 \
--to=joe@perches.com \
--cc=antonysaraev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric.rost@mybabylon.net \
--cc=gregkh@linuxfoundation.org \
--cc=jake@lwn.net \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®