From: Matt Fleming <matt@console-pimps.org>
To: Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Matt Fleming <matt.fleming@intel.com>
Subject: [PATCH 0/2] efi: Remove conditional in_nmi() runtime locking
Date: Wed, 1 Oct 2014 13:06:38 +0100 [thread overview]
Message-ID: <1412165200-32141-1-git-send-email-matt@console-pimps.org> (raw)
From: Matt Fleming <matt.fleming@intel.com>
These two patches should address the concerns raised by Ingo and Peter
in relation to the EFI pull request containing v3.18 material,
https://lkml.kernel.org/r/20140928202702.GB18635@console-pimps.org
We can drop the in_nmi() checks altogether and just provide normal
locking semantics if we introduce a non-blocking SetVariable() operation
for the particular case of writing pstore data to the EFI backend from
the kdump callback, which aborts in the contended case.
This is currently holding up merging of the v3.18 EFI patches, so please
be timely with comments, if any.
@Linaro guys, I don't think you'll actually care all that much about
these changes since the in_nmi() goo was for x86's benefit, but I'm
Cc'ing you anyway to make sure everything looks OK.
Matt Fleming (2):
efi: Provide a non-blocking SetVariable() operation
efi: Delete the in_nmi() conditional runtime locking
arch/x86/include/asm/efi.h | 2 --
drivers/firmware/efi/runtime-wrappers.c | 36 ++++++++++++++++---------
drivers/firmware/efi/vars.c | 47 +++++++++++++++++++++++++++++++++
include/linux/efi.h | 6 +++++
4 files changed, 76 insertions(+), 15 deletions(-)
--
1.9.3
next reply other threads:[~2014-10-01 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 12:06 Matt Fleming [this message]
2014-10-01 12:06 ` [PATCH 1/2] efi: Provide a non-blocking SetVariable() operation Matt Fleming
2014-10-01 15:26 ` Peter Zijlstra
2014-10-01 16:11 ` Matt Fleming
2014-10-01 12:06 ` [PATCH 2/2] efi: Delete the in_nmi() conditional runtime locking Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412165200-32141-1-git-send-email-matt@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®