mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/pci: Add missing linux/irq.h include
Date: Wed, 01 Oct 2014 11:14:26 -0600	[thread overview]
Message-ID: <1412183666.7360.226.camel@ul30vt.home> (raw)
In-Reply-To: <1412164818-18211-1-git-send-email-thierry.reding@gmail.com>

On Wed, 2014-10-01 at 14:00 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> This code uses the irq_get_msi_desc() function whose prototype is in
> linux/irq.h. Include this header to fix a build failure.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/vfio/pci/vfio_pci_intrs.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index a068bb0d69e5..d6f097b0e0e3 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -15,6 +15,7 @@
>  
>  #include <linux/device.h>
>  #include <linux/interrupt.h>
> +#include <linux/irq.h>
>  #include <linux/eventfd.h>
>  #include <linux/msi.h>
>  #include <linux/pci.h>

Hi Thierry, thanks for the patch.  The call to irq_get_msi_desc()
actually came in as part of a conflict resolution in the next tree.
I've requested that the next spin of linux-next include this header if
the conflict still exists, but I'm also working to make the conflict go
away along with the function call that requires this additional header.
Thanks,

Alex


      reply	other threads:[~2014-10-01 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 12:00 Thierry Reding
2014-10-01 17:14 ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412183666.7360.226.camel@ul30vt.home \
    --to=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®