From: Nitin Kuppelur <nitinkuppelur@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Nitin Kuppelur <nitinkuppelur@gmail.com>
Subject: [PATCH] Staging: rtl8712 removed unnecessary else after return
Date: Thu, 2 Oct 2014 13:33:24 +0200 [thread overview]
Message-ID: <1412249604-3415-1-git-send-email-nitinkuppelur@gmail.com> (raw)
In-Reply-To: <20141002084745.GF23154@mwanda>
Removed unnecessary else after return to solve
checkpatch.pl warning
Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com>
---
drivers/staging/rtl8712/hal_init.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
index 81cd654..fbaba11 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
uint rtl871x_hal_init(struct _adapter *padapter)
{
padapter->hw_init_completed = false;
- if (padapter->halpriv.hal_bus_init == NULL)
+ if (padapter->halpriv.hal_bus_init == NULL ||
+ padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
return _FAIL;
- else {
- if (padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
- return _FAIL;
- }
if (rtl8712_hal_init(padapter) == _SUCCESS)
padapter->hw_init_completed = true;
else {
--
1.9.1
next prev parent reply other threads:[~2014-10-02 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 14:44 Nitin Kuppelur
2014-10-01 17:44 ` Joe Perches
2014-10-02 7:39 ` Nitin Kuppelur
2014-10-02 7:44 ` [PATCH V2] " Nitin Kuppelur
2014-10-02 8:47 ` Dan Carpenter
2014-10-02 11:33 ` Nitin Kuppelur [this message]
2014-10-02 12:32 ` [PATCH V3] " Nitin Kuppelur
2014-10-08 22:44 ` Greg KH
2014-10-09 15:30 ` Nitin Kuppelur
2014-10-09 15:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412249604-3415-1-git-send-email-nitinkuppelur@gmail.com \
--to=nitinkuppelur@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome