From: Mel Gorman <mgorman@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Al Viro <viro@zeniv.linux.org.uk>, Rik van Riel <riel@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Michel Lespinasse <walken@google.com>,
Kirill A Shutemov <kirill.shutemov@linux.intel.com>,
Mel Gorman <mgorman@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/4] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
Date: Thu, 2 Oct 2014 14:29:17 +0100 [thread overview]
Message-ID: <1412256558-9995-4-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1412256558-9995-1-git-send-email-mgorman@suse.de>
PROT_NUMA VMAs are skipped to avoid problems distinguishing between
present, prot_none and special entries. MPOL_MF_LAZY is not visible from
userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
same way task_numa_work does.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
mm/mempolicy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 8f5330d..a5877ce 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
}
if (flags & MPOL_MF_LAZY) {
- change_prot_numa(vma, start, endvma);
+ /* Similar to task_numa_work, skip inaccessible VMAs */
+ if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+ change_prot_numa(vma, start, endvma);
goto next;
}
--
1.8.4.5
next prev parent reply other threads:[~2014-10-02 13:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 13:29 [PATCH 0/4] NUMA balancing related fixlets Mel Gorman
2014-10-02 13:29 ` [PATCH 1/4] mm: remove misleading ARCH_USES_NUMA_PROT_NONE (from Andrew's tree) Mel Gorman
2014-10-02 13:29 ` [PATCH 2/4] mm: migrate: Close race between migration completion and mprotect Mel Gorman
2014-10-02 15:48 ` Rik van Riel
2014-10-02 16:41 ` Linus Torvalds
2014-10-02 13:29 ` Mel Gorman [this message]
2014-10-02 15:51 ` [PATCH 3/4] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY Rik van Riel
2014-10-02 13:29 ` [PATCH 4/4] mm: numa: Do not mark PTEs pte_numa when splitting huge pages Mel Gorman
2014-10-02 15:18 ` Kirill A. Shutemov
2014-10-02 16:19 ` Rik van Riel
2014-10-02 16:36 ` Linus Torvalds
2014-10-02 18:58 ` Sasha Levin
2014-10-02 19:03 ` Linus Torvalds
2014-10-02 19:07 ` Kirill A. Shutemov
2014-10-02 19:12 ` Sasha Levin
2014-10-02 19:26 ` Linus Torvalds
2014-10-02 19:28 ` Rik van Riel
2014-10-02 19:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412256558-9995-4-git-send-email-mgorman@suse.de \
--to=mgorman@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=davej@redhat.com \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome