mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Andy Whitcroft <apw@canonical.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vadim Bendebury <vbendeb@chromium.org>
Subject: Re: checkpatch config symbol description false positive
Date: Thu, 02 Oct 2014 12:53:13 -0700	[thread overview]
Message-ID: <1412279593.3247.73.camel@joe-AO725> (raw)
In-Reply-To: <1412278315.6504.6.camel@x41>

On Thu, 2014-10-02 at 21:31 +0200, Paul Bolle wrote:
> Geert Uytterhoeven schreef op do 02-10-2014 om 21:08 [+0200]:
> > When running checkpatch on
> > http://marc.info/?l=linux-sh&m=141227657322649&w=2
> > I get a false positive about the Kconfig symbol I just introduced, incl. a help
> > text:
> > 
> > WARNING: please write a paragraph that describes the config symbol fully
> > #60: FILE: arch/arm/Kconfig.debug:702:
> > + config DEBUG_SCIF
> 
> When you add one single line to your help (say, "Bla bla.") the warning
> disappears. So you hit this test:
>     "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
> 
> because the paragraph was just three lines. It seems a length of one,
> two, or three lines can be OK. It depends. Perhaps the test should just
> be:
>     [...] && $length);

I generally agree.
I think the 4 line paragraph requirement is a bit much myself.

There is a patch in -next that allows a command line or a
.config file override.

commit 77b0cf564fa797e390e0ea29c953ac32bec87994
Author: Vadim Bendebury <vbendeb@chromium.org>
Date:   Fri Sep 26 10:19:28 2014 +1000

    checkpatch: allow optional shorter config descriptions
    
    This script is used by many other projects, and in some of them the
    requirement of at least 4 line long description for all Kconfig items is
    excessive.  This patch adds a command line option to control the required
    minimum length.
    
    Tested running this script over a patch including a two line config
    description.  The script generated a warning when invoked as is, and did
    not generate it when invoked with --min-conf-desc-length=2.
    
    Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
    Acked-by: Joe Perches <joe@perches.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>




      reply	other threads:[~2014-10-02 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 19:08 cehckpatch " Geert Uytterhoeven
2014-10-02 19:31 ` Paul Bolle
2014-10-02 19:53   ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412279593.3247.73.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=vbendeb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®